From 724aa93ed5ebbab7eaf10db0b64e934293f78ea9 Mon Sep 17 00:00:00 2001 From: Francesco Chemolli Date: Mon, 6 Jan 2025 23:28:24 +0000 Subject: [PATCH 1/3] BUG 5093: clarify https_port documentation --- src/cf.data.pre | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/cf.data.pre b/src/cf.data.pre index c9da24e317b..24f89dce90e 100644 --- a/src/cf.data.pre +++ b/src/cf.data.pre @@ -2575,6 +2575,9 @@ DOC_START The tls-cert= option is mandatory on HTTPS ports. See http_port for a list of modes and options. + + http_port options not supported for https_port: + - require-proxy-header DOC_END NAME: ftp_port @@ -2639,6 +2642,10 @@ DOC_START Other http_port modes and options that are not specific to HTTP and HTTPS may also work. + + http_port options not supported for https_port: + - require-proxy-header + - ssl-bump DOC_END NAME: tcp_outgoing_tos tcp_outgoing_ds tcp_outgoing_dscp From 46991ea029a8b2cf1a7dc579ca06d8dda6c3bdaa Mon Sep 17 00:00:00 2001 From: Francesco Chemolli Date: Tue, 7 Jan 2025 23:17:27 +0000 Subject: [PATCH 2/3] Reword --- src/cf.data.pre | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/cf.data.pre b/src/cf.data.pre index 24f89dce90e..789a566a031 100644 --- a/src/cf.data.pre +++ b/src/cf.data.pre @@ -2575,9 +2575,9 @@ DOC_START The tls-cert= option is mandatory on HTTPS ports. See http_port for a list of modes and options. - - http_port options not supported for https_port: - - require-proxy-header + Not all http_port options are supported for https_port. + Among the unsupported options: + - require-proxy-header DOC_END NAME: ftp_port @@ -2642,10 +2642,9 @@ DOC_START Other http_port modes and options that are not specific to HTTP and HTTPS may also work. - - http_port options not supported for https_port: - - require-proxy-header - - ssl-bump + Among the options that are not available for ftp_port: + - require-proxy-header + - ssl-bump DOC_END NAME: tcp_outgoing_tos tcp_outgoing_ds tcp_outgoing_dscp From deb7169fc0e95e638d7ada90305200fe7a3af663 Mon Sep 17 00:00:00 2001 From: Francesco Chemolli Date: Tue, 7 Jan 2025 23:20:41 +0000 Subject: [PATCH 3/3] better consistency --- src/cf.data.pre | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cf.data.pre b/src/cf.data.pre index 789a566a031..770ab0abfd8 100644 --- a/src/cf.data.pre +++ b/src/cf.data.pre @@ -2575,8 +2575,8 @@ DOC_START The tls-cert= option is mandatory on HTTPS ports. See http_port for a list of modes and options. - Not all http_port options are supported for https_port. - Among the unsupported options: + Not all http_port options are available for https_port. + Among the unavalable options: - require-proxy-header DOC_END