Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name not matching with the README markdown #11

Open
srinibasbiswal opened this issue Oct 1, 2020 · 8 comments
Open

Name not matching with the README markdown #11

srinibasbiswal opened this issue Oct 1, 2020 · 8 comments
Labels
bug Something isn't working Hacktoberfest Issue to contribute for Hacktoberfest Hacktoberfest2020 Issue to contribute for Hacktoberfest 2020 help wanted Extra attention is needed

Comments

@srinibasbiswal
Copy link
Owner

Sometimes the name is not matching with the markdown README. It is getting resolved after hard reloading. But sometimes it takes up to 2-3 hard reloads to fix.

@srinibasbiswal srinibasbiswal added bug Something isn't working Hacktoberfest Issue to contribute for Hacktoberfest help wanted Extra attention is needed labels Oct 1, 2020
@gioboa
Copy link
Contributor

gioboa commented Oct 1, 2020

Can I take this?

@srinibasbiswal
Copy link
Owner Author

sure @gioboa

@srinibasbiswal
Copy link
Owner Author

Hi @gioboa , I have merged the PR #16 , but the issue is still present. So keeping this issue open. Thanks for the cache suggestion.

@srinibasbiswal
Copy link
Owner Author

One thing I noticed, the issue comes after deployment and after hard-refreshing, the issue doesn't come anymore. Again when deployment happens, the issue comes again.
Deployment Structure: After every commit, the project gets builds and the build folder gets deployed to firebase hosting.
I am guessing either its a deployment issue or a cache issue.

@srinibasbiswal srinibasbiswal added the Hacktoberfest2020 Issue to contribute for Hacktoberfest 2020 label Oct 1, 2020
@gioboa
Copy link
Contributor

gioboa commented Oct 1, 2020

Maybe this answer fit this issue

@srinibasbiswal
Copy link
Owner Author

Thanks, @gioboa for the suggestion. I have implemented that. This time after the deployment, I didn't do any hard reloads and the data is loading as expected. Still, I will wait for 1 more day and observe if it's really solved. Really appreciate your help.

@gioboa
Copy link
Contributor

gioboa commented Oct 1, 2020

Glad to help you 🚀 💪

@srinibasbiswal
Copy link
Owner Author

The issue is still there. I tried triaging the issue. These are my observations :

  • Only data of consecutive files are exchanged.
  • Currently, onLoad all the markdown files are read using Promise.all().
  • It is returning only the data of the files, so another list is maintained to keep the record of the sequence in which the file names were read.
  • There is a chance that the sequence and the data that is returned is not matching.
  • Possible file whee=re the issue is occurring : src/containers/WallContainer.js

This issue will be tracked on another branch. issue#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest Issue to contribute for Hacktoberfest Hacktoberfest2020 Issue to contribute for Hacktoberfest 2020 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants