Issue with Snobal module: Liquid water stored in snowpack dissapears if new snow is added on the current time step

[acebulsk]

The if statement referenced by the link below should likely be removed, otherwise liquid water stored in the snowpack in the variable h2o[hh] is only retained when new snow is added to the snowpack.

crhmcode/crhmcode/src/modules/ClassSnobalBase.cpp

Line 1213 in 612abca

else // no precip

If I have this right, it is a pretty big impact (snow melts out ~ 3 days earlier and peak SWE is 10-50 mm less with this bug fixed).

[lawfordp2017]

I agree on this, it seems the original SNOBAL code was coded differently: https://github.com/USDA-ARS-NWRC/pysnobal/blob/master/pysnobal/c_snobal/libsnobal/_precip.c