Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and improve expectations around corner numbering and ordering #46

Open
PeterJCLaw opened this issue Aug 9, 2023 · 0 comments
Open

Comments

@PeterJCLaw
Copy link
Member

Following from PeterJCLaw/srcomp#27 it seems that this repo relies on the ordering of the keys in the mapping returned from /corners is the same as the order of the list of teams in a match. This appears to currently work, however this is due to us always naming corners 0, 1, 2 and 3 in that order.

It is unclear whether this is something that should be relied upon -- specifically whether JSON & JavaScript mappings' keys have defined stable orderings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant