Skip to content

Commit 4301b09

Browse files
authored
Merge pull request #38 from ssciwr/fixup-version-relax
Fix up detection of version 8
2 parents 9a82cd9 + db04685 commit 4301b09

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414

1515
jobs:
1616
testing:
17-
name: Unit Testing (Python ${{ matrix.python }})
17+
name: Unit Testing (Python ${{ matrix.python }}, ipywidgets${{ matrix.ipywidgets }})
1818
runs-on: ubuntu-20.04
1919
strategy:
2020
matrix:
@@ -23,6 +23,9 @@ jobs:
2323
- "3.8"
2424
- "3.9"
2525
- "3.10"
26+
ipywidgets:
27+
- "<8"
28+
- "==8.0.0rc0"
2629

2730
steps:
2831
- name: Checkout repository
@@ -35,6 +38,7 @@ jobs:
3538

3639
- name: Install package and development dependencies
3740
run: |
41+
python -m pip install "ipywidgets${{ matrix.ipywidgets }}"
3842
python -m pip install .
3943
python -m pip install -r requirements-dev.txt
4044

ipywidgets_jsonschema/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
from ipywidgets_jsonschema.form import Form
22

3-
__version__ = "0.8.0"
3+
__version__ = "0.8.1"

ipywidgets_jsonschema/form.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212

1313
# We are providing some compatibility for ipywidgets v7 and v8
14-
IS_VERSION_8 = version.parse(ipywidgets.__version__) >= version.parse("8")
14+
IS_VERSION_8 = version.parse(ipywidgets.__version__).major == 8
1515

1616

1717
class FormError(Exception):

0 commit comments

Comments
 (0)