Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline config handling #1592

Open
Starkteetje opened this issue Apr 26, 2024 · 0 comments
Open

Streamline config handling #1592

Starkteetje opened this issue Apr 26, 2024 · 0 comments

Comments

@Starkteetje
Copy link
Member

Describe the bug
Currently, we mostly parse config in config.go, but keep the deployment, application.features, and application.logLevel keys separate. While the deployment key makes sense in that it pertains only to resources deployed via Helm and as such never really reaches the Connaisseur application, the application keys stands out as something that is passed to Connaisseur via env vars and is handled by feature.go and logging.go.

I think this is a remnant of the way we handled it in Python (read: is technical debt) and there's no reason to pass parts of the application config via the environment.

Expected behavior
As a developer with a config object, I have all the config I need, i.e. I don't need to handle two different ways of changing config options if I want to change something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant