Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing DSR #4

Open
danicuki opened this issue Apr 29, 2015 · 3 comments
Open

Implementing DSR #4

danicuki opened this issue Apr 29, 2015 · 3 comments

Comments

@danicuki
Copy link

Hi @sshaw - Any idea of when DSR will be implemented? I could help with it, if you give me the path

@sshaw
Copy link
Owner

sshaw commented Apr 30, 2015

Hi, implementing it should be relatively easy depending on how jaxb2ruby performs with the DSR schema and how much tweaking the fixture generating config requires. I see you've already got a good start, though I see an issue or two. I'll comment inline on your commit.

I've added a contributing document that outlines what's needed. Let me know how it looks.

A couple notes:

  1. The shared examples for metadata serialization should be put into a place where it can be reused for DSR.
  2. We'll also need to figure out how to auto detect the spec so DDEX.read and DDEX.write can delegate to the proper spec's method

@sshaw
Copy link
Owner

sshaw commented May 21, 2015

Any luck with the DSR implementation @danicuki?

@danicuki
Copy link
Author

Hi @sshaw,

I didn’t have time to work on it. I needed a very specific usage of DDEX, so I decided to use Nokogiri and SAX to parse the xml directly and grab the fields I needed. I hope I have some time in future to finish this contribution

Best

D

On Thu, May 21, 2015 at 1:55 AM, Skye Shaw notifications@github.com
wrote:

Any luck with the DSR implementation @danicuki?

Reply to this email directly or view it on GitHub:
#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants