Add negative test for data values that cannot be json-encoded

Author: st3v

glager.go

@@ -217,10 +217,8 @@ func (actual logEntryData) contains(expected logEntryData) (bool, error) {
 			return false, nil
 		}
 
-		actualJSON, err := json.Marshal(actualVal)
-		if err != nil {
-			return false, err
-		}
+		// this has been marshalled and unmarshalled before, no need to check err
+		actualJSON, _ := json.Marshal(actualVal)
 
 		expectedJSON, err := json.Marshal(expectedVal)
 		if err != nil {

glager_test.go

@@ -11,6 +11,7 @@ import (
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 	"github.com/onsi/gomega/gbytes"
+	"github.com/onsi/gomega/types"
 	"github.com/pivotal-golang/lager"
 	"github.com/pivotal-golang/lager/lagertest"
 	. "github.com/st3v/glager"
@@ -552,10 +553,11 @@ var _ = Describe(".ContainSequence", func() {
 		var (
 			buffer  *gbytes.Buffer
 			logger  lager.Logger
-			matcher = ContainSequence(Info())
+			matcher types.GomegaMatcher
 		)
 
 		BeforeEach(func() {
+			matcher = ContainSequence(Info())
 			buffer = gbytes.NewBuffer()
 			logger = lager.NewLogger("logger")
 			logger.RegisterSink(lager.NewWriterSink(buffer, lager.DEBUG))
@@ -661,6 +663,19 @@ var _ = Describe(".ContainSequence", func() {
 					Expect(err).To(BeAssignableToTypeOf(&json.SyntaxError{}))
 				})
 			})
+
+			Context("when expected contains non-encodable data values", func() {
+				BeforeEach(func() {
+					actual = buffer
+					logger.Info("foo", lager.Data{"foo": "bar"})
+					matcher = ContainSequence(Info(Data("foo", func() {})))
+				})
+
+				It("returns a json.UnsupportedType error", func() {
+					Expect(err).To(HaveOccurred())
+					Expect(err).To(BeAssignableToTypeOf(&json.UnsupportedTypeError{}))
+				})
+			})
 		})
 
 		Describe("FailureMessage", func() {