Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placement in Items #4

Closed
m-mohr opened this issue Apr 5, 2024 · 2 comments · Fixed by #5
Closed

Placement in Items #4

m-mohr opened this issue Apr 5, 2024 · 2 comments · Fixed by #5

Comments

@m-mohr
Copy link

m-mohr commented Apr 5, 2024 •
edited
Loading

The specification says "renders" should be in Item Properties, but the examples and schema seem to have it on the top-level. I think it should in the Item Properties. All extensions extend the Item Properties, which is the best-practice.
@m-mohr m-mohr mentioned this issue Apr 5, 2024
Closed
@giorgiobasile giorgiobasile mentioned this issue Apr 15, 2024
Merged
@giorgiobasile
Copy link
Contributor

Hi, just letting you know I just made #5 open for reviews. I'm not very skilled with JSON Schema but I'd be happy to contribute :)

@emmanuelmathot
Copy link
Member

Just reviewed. We will need a version 2 as it is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Places renders object in Item properties giorgiobasile/stac-render-extension
3 participants
@emmanuelmathot @giorgiobasile @m-mohr