From 4c0e74e0704f4018d8c548dc65b00598462136ca Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Tue, 19 Sep 2023 13:42:45 +0200 Subject: [PATCH] fixes --- .../contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc b/modules/contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc index c8cdd294c..eb5c9655e 100644 --- a/modules/contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc +++ b/modules/contributor/pages/adr/ADR030-reduce-pod-disruptions.adoc @@ -11,12 +11,13 @@ v0.1, 2023-09-15 == Context and Problem Statement Downtime of products is always bad. -Kubernetes has a a concepts called https://kubernetes.io/docs/tasks/run-application/configure-pdb/[PodDisruptionBudget] (PDB) to try to reduce this to an absolute minimum. +Kubernetes has a a concepts called https://kubernetes.io/docs/tasks/run-application/configure-pdb/[PodDisruptionBudget] (PDB) to prevent this. +We want to use this functionary to try to reduce the downtime to an absolute minimum. *Requirements:* 1. We must deploy a PDB alongside all the product StatefulSets (and Deployments in the future) to restrict pod disruptions. -2. Also users need to ability to override the numbers we default to, as they need to make a tradeoff between availability and rollout times e.g. in rolling redeployment. Context: I have operated Trino clusters that could take more than 6 hours to rolling redeploy, as the graceful shutdown of Trino workers takes a considerable amount of time - depended on the queries getting executed. +2. Also users need the ability to override the numbers we default to, as they need to make a tradeoff between availability and rollout times e.g. in rolling redeployment. Context: I have operated Trino clusters that could take more than 6 hours to rolling redeploy, as the graceful shutdown of Trino workers takes a considerable amount of time - depended on the queries getting executed. We have the following constraints: