Skip to content

Commit b9b6100

Browse files
committed
cleaned up some comments, removed Tgz case
1 parent b0fbdfc commit b9b6100

File tree

11 files changed

+31
-46
lines changed

11 files changed

+31
-46
lines changed

extra/completions/_stackablectl

Lines changed: 6 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/completions/stackablectl.bash

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/completions/stackablectl.fish

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/completions/stackablectl.nu

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/stackable-cockpit/src/platform/manifests.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ pub enum Error {
6262

6363
pub trait InstallManifestsExt {
6464
// TODO (Techassi): This step shouldn't care about templating the manifests nor fetching them from remote
65-
// TODO aken: do we support helm charts from registries?
6665
#[instrument(skip_all)]
6766
#[allow(async_fn_in_trait)]
6867
async fn install_manifests(
@@ -95,7 +94,7 @@ pub trait InstallManifestsExt {
9594
helm_chart.name, helm_chart.version
9695
);
9796

98-
// TODO aken: assuming all manifest helm charts refer to repos not registries
97+
// Assumption: that all manifest helm charts refer to repos not registries
9998
helm::add_repo(&helm_chart.repo.name, &helm_chart.repo.url).context(
10099
AddHelmRepositorySnafu {
101100
repo_name: helm_chart.repo.name.clone(),

rust/stackable-cockpit/src/platform/operator/mod.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ impl OperatorSpec {
194194
let chart_source = match chart_source {
195195
ChartSourceType::OCI => HELM_OCI_REGISTRY.to_string(),
196196
ChartSourceType::Repo => self.helm_repo_name(),
197-
ChartSourceType::Tgz => "TODO".to_string(),
198197
};
199198

200199
// Install using Helm
@@ -237,9 +236,6 @@ pub enum ChartSourceType {
237236

238237
/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus may be operator-specific
239238
Repo,
240-
241-
/// Archive
242-
Tgz,
243239
}
244240

245241
#[cfg(test)]

0 commit comments

Comments
 (0)