Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzlmod support #319

Open
siddharthab opened this issue Apr 29, 2023 · 5 comments · May be fixed by #377
Open

bzlmod support #319

siddharthab opened this issue Apr 29, 2023 · 5 comments · May be fixed by #377

Comments

@siddharthab
Copy link

Would you accept a PR for bzlmod support? Anything I should keep in mind while working on this?

@kyleconroy
Copy link

Would love this as well!

@Sovietaced
Copy link

Sovietaced commented Aug 17, 2023

I am maintaining a fork of this at work that supports bzlmod but it only supports a subset of features (go, grpc-gateway, grpc-gateway-openapi). I have found it particularly challenging to get ts to work because of API changes in the rules_nodejs.

If there is a way to do a gradual migration I'd be happy to help, but this is a non trivial ask imo.

@siddharthab
Copy link
Author

I also looked at this more after creating the issue and thought that this is going to be non-trivial and span multiple projects. I also don't see any interest from the repo owners/maintainers at this time.

My own team may not be using this in the long term, so I am currently not willing to put in efforts into this.

@pcj
Copy link
Member

pcj commented Feb 17, 2024

bzlmod support is planned by definitely a non-trivial task. Happy to review PRs.

@pcj
Copy link
Member

pcj commented Jul 1, 2024

Opened at PR: #377

@pcj pcj linked a pull request Jul 1, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants