fix(create-pr): Removed files were not recognised (#206)

Additionally added a warning message for skipped services to all generate methods

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>

Author: Fyusel

scripts/generate-sdk/languages/go.sh

@@ -106,6 +106,8 @@ generate_go_sdk() {
         go work use .
     fi
 
+    warning=""
+
     # Generate SDK for each service
     for service_json in ${ROOT_DIR}/oas/*.json; do
         service="${service_json##*/}"
@@ -132,6 +134,7 @@ generate_go_sdk() {
 
         if grep -E "^$service$" ${ROOT_DIR}/blacklist.txt; then
             echo "Skipping blacklisted service ${service}"
+            warning+="Skipping blacklisted service ${service}\n"
             continue
         fi
 
@@ -238,4 +241,8 @@ generate_go_sdk() {
     cd ${SDK_REPO_LOCAL_PATH}
     goimports -w ${SERVICES_FOLDER}/
     make sync-tidy
+
+    if [[ -n "$warning" ]]; then
+        echo -e "\nSome of the services were skipped during creation!\n$warning"
+    fi
 }

scripts/generate-sdk/languages/java.sh

@@ -74,6 +74,8 @@ generate_java_sdk() {
     # Remove old contents of services dir (services/)
     rm -rf "${SERVICES_FOLDER}"
 
+    warning=""
+
     # Generate SDK for each service
     for service_json in "${ROOT_DIR}"/oas/*.json; do
         service="${service_json##*/}"
@@ -94,11 +96,13 @@ generate_java_sdk() {
 
         if ! [[ ${INCLUDE_SERVICES[*]} =~ ${service} ]]; then
             echo "Skipping not included service ${service}"
+            warning+="Skipping not included service ${service}\n"
             continue
         fi
 
         if grep -E "^$service$" "${ROOT_DIR}/blacklist.txt"; then
             echo "Skipping blacklisted service ${service}"
+            warning+="Skipping blacklisted service ${service}\n"
             continue
         fi
 
@@ -172,6 +176,10 @@ generate_java_sdk() {
 
     cd "${SDK_REPO_LOCAL_PATH}"
     make fmt
+
+    if [[ -n "$warning" ]]; then
+        echo -e "\nSome of the services were skipped during creation!\n$warning"
+    fi
 }
 
 to_pascal_case() {

scripts/generate-sdk/languages/python.sh

@@ -78,6 +78,8 @@ generate_python_sdk() {
     # Remove old contents of services dir (services/)
     rm -rf ${SERVICES_FOLDER}
 
+    warning=""
+
     # Generate SDK for each service
     for service_json in ${ROOT_DIR}/oas/*.json; do
         service="${service_json##*/}"
@@ -92,6 +94,7 @@ generate_python_sdk() {
 
         if grep -E "^$service$" ${ROOT_DIR}/blacklist.txt; then
             echo "Skipping blacklisted service ${service}"
+            warning+="Skipping blacklisted service ${service}\n"
             continue
         fi
 
@@ -174,4 +177,8 @@ generate_python_sdk() {
         black .
 
     done
+
+    if [[ -n "$warning" ]]; then
+        echo -e "\nSome of the services were skipped during creation!\n$warning"
+    fi
 }

scripts/sdk-create-pr.sh

@@ -74,7 +74,7 @@ for service_path in ${work_dir}/sdk_to_push/services/*; do
     # Replace old SDK with new one
     # Removal of pulled data is necessary because the old version may have files
     # that were deleted in the new version
-    rm -rf "./services/${service}/*"
+    rm -rf "./services/${service}"
     cp -a "${work_dir}/sdk_to_push/services/${service}/." "./services/${service}"
 
     # Check for changes in the specific folder compared to main