Skip to content

Conversation

@VisruthSK
Copy link
Member

@VisruthSK VisruthSK commented Dec 1, 2025

Swap to new site, build on releases and pushes to master.

@VisruthSK VisruthSK marked this pull request as ready for review December 3, 2025 19:30
@VisruthSK VisruthSK requested a review from jgabry December 3, 2025 19:30
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just made a couple of questions about the logo file. Also, it doesn't look like the dev site rendered. Is that just because you did [ci skip] and it avoided running the workflow?

@VisruthSK
Copy link
Member Author

Ah the dev site didn't render because the package is marked as a release version still: Version: 2.6.0

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Ah the dev site didn't render because the package is marked as a release version still: Version: 2.6.0

Oh, oops. Let me bump the version to a dev version on master and then we can merge that into this branch.

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Ok just bumped the version number to the dev version

@VisruthSK
Copy link
Member Author

Hm its queueing the build but there aren't any live predecessors.

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Could that be because there are a bunch of other workflows are currently running in the stan-dev organization? I think there are org concurrency limits.

@VisruthSK
Copy link
Member Author

Makes sense that's probably it.

@VisruthSK
Copy link
Member Author

Seems to be working

@jgabry
Copy link
Member

jgabry commented Dec 4, 2025

Seems like it the main site is up now too, not just the dev version. Was that intentional? (Not a big deal, just curious.) The site looks good, the only issue I noticed is that there are some missing example images: https://mc-stan.org/shinystan/#screenshots. Here's what they look like in the readme: https://github.com/stan-dev/shinystan/?tab=readme-ov-file#screenshots. We don't necessarily need those, but it's nice to have some images.

@VisruthSK
Copy link
Member Author

Not intentional, surprised that happened. Usually its because I've not been good about checking the version and making sure to set development mode to auto, but I thought both were set properly here. I know whats the issue with the images and will fix it now.

@jgabry
Copy link
Member

jgabry commented Dec 4, 2025

Thanks, images are fixed on the dev site, but not on the main site that was mysteriously created. I guess that will get fixed automatically when I do the release?

@VisruthSK
Copy link
Member Author

VisruthSK commented Dec 4, 2025 via email

@jgabry jgabry merged commit bc87367 into master Dec 8, 2025
@jgabry jgabry deleted the new-pkgdown-theme branch December 8, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants