-
-
Notifications
You must be signed in to change notification settings - Fork 47
Added pkgdown workflow #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just made a couple of questions about the logo file. Also, it doesn't look like the dev site rendered. Is that just because you did [ci skip] and it avoided running the workflow?
|
Ah the dev site didn't render because the package is marked as a release version still: |
Oh, oops. Let me bump the version to a dev version on master and then we can merge that into this branch. |
|
Ok just bumped the version number to the dev version |
|
Hm its queueing the build but there aren't any live predecessors. |
|
Could that be because there are a bunch of other workflows are currently running in the stan-dev organization? I think there are org concurrency limits. |
|
Makes sense that's probably it. |
|
Seems to be working |
|
Seems like it the main site is up now too, not just the dev version. Was that intentional? (Not a big deal, just curious.) The site looks good, the only issue I noticed is that there are some missing example images: https://mc-stan.org/shinystan/#screenshots. Here's what they look like in the readme: https://github.com/stan-dev/shinystan/?tab=readme-ov-file#screenshots. We don't necessarily need those, but it's nice to have some images. |
|
Not intentional, surprised that happened. Usually its because I've not been good about checking the version and making sure to set development mode to auto, but I thought both were set properly here. I know whats the issue with the images and will fix it now. |
|
Thanks, images are fixed on the dev site, but not on the main site that was mysteriously created. I guess that will get fixed automatically when I do the release? |
|
Yup it should
…On December 4, 2025 7:38:07 PM UTC, Jonah Gabry ***@***.***> wrote:
jgabry left a comment (stan-dev/shinystan#206)
Thanks, images are fixed on the dev site, but not on the main site that was mysteriously created. I guess that will get fixed automatically when I do the release?
--
Reply to this email directly or view it on GitHub:
#206 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This reverts commit cc223b0.
Swap to new site, build on releases and pushes to master.