You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RunSpec.annotators should be named RunSpec.annotator_specs
Annotators should support concurrency. AnnotatorFactory.get_annotator() should not enforce singletons. The image2structure annotators should be using locks instead. This is a correctness issue - currently, if multiple annotators with different arguments are instantiated, the run could get an annotator with the wrong arguments.
Annotator cache directory should be based on the name field, rather than the class name. For instance, the folder for LatexCompilerAnnotator should be latex_compiler, not latexcompiler.
RunSpec.annotators
should be namedRunSpec.annotator_specs
AnnotatorFactory.get_annotator()
should not enforce singletons. The image2structure annotators should be using locks instead. This is a correctness issue - currently, if multiple annotators with different arguments are instantiated, the run could get an annotator with the wrong arguments.name
field, rather than the class name. For instance, the folder forLatexCompilerAnnotator
should belatex_compiler
, notlatexcompiler
.The text was updated successfully, but these errors were encountered: