Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Interact With .gate files. #154

Open
Pheotis opened this issue May 25, 2022 · 3 comments
Open

API: Interact With .gate files. #154

Pheotis opened this issue May 25, 2022 · 3 comments
Labels
enhancement A suggested addition to the plugin. On Hold! Something is currently preventing us from working on this; we will work on it when we can! REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)

Comments

@Pheotis
Copy link

Pheotis commented May 25, 2022

Ability to get, add, alter, etc gate designs.

Might be worth delaying until 1.0.2.0 and lumping the features required for this in with the gate format rework / gatepack implementation.

@Pheotis Pheotis added REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA) On Hold! Something is currently preventing us from working on this; we will work on it when we can! labels May 25, 2022
@Pheotis Pheotis added this to the 1.0.2.0 milestone May 25, 2022
@Pheotis Pheotis added the enhancement A suggested addition to the plugin. label May 25, 2022
@Thorinwasher
Copy link

I have some questions regarding this

  • altering or deliting a gateformat might mess up already existing portals with said format. Should we really support that?
  • What does getting formats mean? Getting them from a portal or getting it by name?
    I can see the add gateFormat being used though. I think this part of the api needs some more thought

@EpicKnarvik97
Copy link
Collaborator

EpicKnarvik97 commented Jun 6, 2022

Getting gates can be for the purpose of checking if a given design exists. It can also be used for some kind of visualizer which displays gate designs in the chat.

If we delete a gate format using the API, we should require that no portals are using the gate format, and throw an error, or something, if it's in use. Altering the open and closed materials shouldn't be as much of a problem, but altering the frame shouldn't be allowed if the gate format is in use and gate verification is enabled.

Being able to add gate formats through the API makes it possible to simply build a Stargate, and make it into a .gate file through commands. I'm pretty sure I saw some code in the legacy SG-Command which did exactly this.

@Pheotis Pheotis modified the milestones: 1.2.0.0, Distant Future (1.2.0.0+) Jan 2, 2023
@Thorinwasher
Copy link

Thorinwasher commented Jan 13, 2024

What has been implemented so far:

  • Add gate formats
  • Remove gate formats with check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggested addition to the plugin. On Hold! Something is currently preventing us from working on this; we will work on it when we can! REWRITE This task/issue only applies to the rewritten version of the plugin (currently in ALPHA)
Projects
Development

No branches or pull requests

3 participants