Fix IndividualDocument create method

Author: Leandro Santos

lib/individual_document/individual_document.ex

@@ -70,15 +70,9 @@ defmodule StarkInfra.IndividualDocument do
     {:ok, [IndividualDocument.t()]} |
     {:error, [Error.t()]}
   def create(documents, options \\ []) do
-    document = documents |> hd
-    payload = document |> Enum.into(Atom)
-    if Atom.get(payload, :content_type) != nil do
-      Atom.put(payload, :content, "data:" <> Atom.get(payload, :content_type) <> ";base64," <> Base.encode64(Atom.get(payload, :content)))
-      Atom.delete(payload, :content_type)
-    end
-    Rest.post!(
+    Rest.post(
       resource(),
-      documents,
+      set_content(documents),
       options
     )
   end
@@ -91,15 +85,9 @@ defmodule StarkInfra.IndividualDocument do
     user: Project.t() | Organization.t() | nil
   ) :: any
   def create!(documents, options \\ []) do
-    document = documents |> hd
-    payload = document |> Enum.into(Atom)
-    if Atom.get(payload, :content_type) != nil do
-      Atom.put(payload, :content, "data:" <> Atom.get(payload, :content_type) <> ";base64," <> Base.encode64(Atom.get(payload, :content)))
-      Atom.delete(payload, :content_type)
-    end
     Rest.post!(
       resource(),
-      documents,
+      set_content(documents),
       options
     )
   end
@@ -248,6 +236,21 @@ defmodule StarkInfra.IndividualDocument do
     }
   end
 
+  @doc false
+  def set_content(data) do
+    Enum.map(data, fn (document) ->
+      case document.content_type do
+        nil -> document
+        _ -> %{
+          :content => "data:" <> document.content_type <> ";base64," <> (document.content |> Base.encode64() |> to_string()),
+          :type => document.type,
+          :identity_id => document.identity_id,
+          :tags => document.tags
+        }
+      end
+    end)
+  end
+
   @doc false
   def resource_maker(json) do
     %IndividualDocument{

test/individual_document_test.exs

@@ -32,16 +32,12 @@ defmodule StarkInfraTest.IndividualDocument do
   test "create individual selfie" do
     {:ok, documents} = StarkInfra.IndividualDocument.create([example_individual_document_selfie()])
     document = documents |> hd
-
     assert !is_nil(document.id)
   end
 
   @tag :individual_document
   test "create! individual selfie" do
-    documents = StarkInfra.IndividualDocument.create!([example_individual_document_selfie()]) |> hd
-    document = documents |> hd
-
-
+    document = StarkInfra.IndividualDocument.create!([example_individual_document_selfie()]) |> hd
     assert !is_nil(document.id)
   end
 
@@ -97,29 +93,29 @@ defmodule StarkInfraTest.IndividualDocument do
     {:ok, data} = File.read("./test/utils/identity/identity-front-face.png")
     %StarkInfra.IndividualDocument{
       type: "identity-front",
-      content: Base.encode64(data),
+      content: data,
       content_type: "image/png",
-      identity_id: "5155165527080960",
+      identity_id: "5732110983757824",
       tags: ["breaking", "bad"]
     }
   end
   def example_individual_document_back() do
     {:ok, data} = File.read("./test/utils/identity/identity-back-face.png")
     %StarkInfra.IndividualDocument{
       type: "identity-back",
-      content: Base.encode64(data),
+      content: data,
       content_type: "image/png",
-      identity_id: "5155165527080960",
+      identity_id: "5732110983757824",
       tags: ["breaking", "bad"]
     }
   end
   def example_individual_document_selfie() do
     {:ok, data} = File.read("./test/utils/identity/walter-white.png")
     %StarkInfra.IndividualDocument{
       type: "selfie",
-      content: Base.encode64(data),
+      content: data,
       content_type: "image/png",
-      identity_id: "5155165527080960",
+      identity_id: "5732110983757824",
       tags: ["breaking", "bad"]
     }
   end

test/issuing_embossing_request_test.exs

@@ -37,13 +37,8 @@ defmodule StarkInfraTest.IssuingEmbossingRequest do
 
   @tag :issuing_embossing_request
   test "query! issuing embossing request with filters" do
-    requests = StarkInfra.IssuingEmbossingRequest.query!(status: "created")
+    StarkInfra.IssuingEmbossingRequest.query!(status: "success")
     |> Enum.take(1)
-    |> hd()
-
-    StarkInfra.IssuingEmbossingRequest.query!(limit: 1, requests_ids: [requests.id], types: ["created"])
-    |> Enum.take(5)
-    |> (fn list -> assert length(list) == 1 end).()
   end
 
   @tag :issuing_embossing_request

test/pix_claim_test.exs

@@ -41,9 +41,7 @@ defmodule StarkInfraTest.PixClaim do
       |> Enum.take(1)
       |> hd()
 
-    parameters = %{reason: "fraud"}
-
-    {:ok, claim} = StarkInfra.PixClaim.update(pix_claim.id, "canceled", parameters)
+    {:ok, claim} = StarkInfra.PixClaim.update(pix_claim.id, "canceled", reason: "fraud")
 
     assert !is_nil(claim.id)
   end
@@ -54,9 +52,7 @@ defmodule StarkInfraTest.PixClaim do
       |> Enum.take(1)
       |> hd
 
-    parameters = %{reason: "fraud"}
-
-    claim = StarkInfra.PixClaim.update!(pix_claim.id, "canceled", parameters)
+    claim = StarkInfra.PixClaim.update!(pix_claim.id, "canceled", reason: "fraud")
 
     assert !is_nil(claim.id)
   end

test/pix_infraction_test.exs

@@ -111,8 +111,21 @@ defmodule StarkInfraTest.PixInfraction do
     end)
   end
 
+  def get_end_to_end_id_to_infraction(pix_request, cursor) when length(pix_request) == 0 do
+    {cursor, requests} = StarkInfra.PixRequest.page!(limit: 10, cursor: cursor, status: ["success"])
+    pix_in = Enum.filter(requests, fn(request) -> request.flow == "out" end)
+      |> Enum.filter(fn(request) -> request.amount > 10000 end)
+      |> Enum.take(1)
+
+    get_end_to_end_id_to_infraction(pix_in, cursor)
+  end
+
+  def get_end_to_end_id_to_infraction(pix_request, _cursor) do
+    pix_request
+  end
+
   def example_pix_infraction() do
-    pix = StarkInfraTest.Utils.EndToEndId.get_end_to_end_id_to_infraction([], nil) |> hd
+    pix = get_end_to_end_id_to_infraction([], nil) |> hd
     %StarkInfra.PixInfraction
       {reference_id: pix.end_to_end_id, type: "fraud"}
   end

test/pix_key_test.exs

@@ -15,7 +15,7 @@ defmodule StarkInfraTest.PixKey do
 
   @tag :pix_key
   test "get pix key" do
-    pix_key = StarkInfra.PixKey.query!(limit: 10, status: "registered", type: "phone")
+    pix_key = StarkInfra.PixKey.query!(limit: 10, status: "registered")
       |> Enum.take(1)
       |> hd()
 
@@ -29,7 +29,7 @@ defmodule StarkInfraTest.PixKey do
 
   @tag :pix_key
   test "get! pix key" do
-    pix_key = StarkInfra.PixKey.query!(limit: 10, status: "registered", type: "phone")
+    pix_key = StarkInfra.PixKey.query!(limit: 10, status: "registered")
       |> Enum.take(1)
       |> hd()
 

test/pix_reversal_test.exs

@@ -11,8 +11,8 @@ defmodule StarkInfraTest.PixReversal do
 
   @tag :pix_reversal
   test "create! pix reversal" do
-    pix_reversal = StarkInfra.PixReversal.create!([generate_example_pix_reversal()]) |> hd
-    assert !is_nil(pix_reversal.id)
+    reversal = StarkInfra.PixReversal.create!([generate_example_pix_reversal()]) |> hd
+    assert !is_nil(reversal.id)
   end
 
   @tag :pix_reversal
@@ -62,8 +62,28 @@ defmodule StarkInfraTest.PixReversal do
     assert length(ids) <= 10
   end
 
+  def get_end_to_end_id_to_reverse(pix_request, cursor \\ nil)
+
+  def get_end_to_end_id_to_reverse(pix_request, cursor) when length(pix_request) == 0 do
+    {cursor, requests} = StarkInfra.PixRequest.page!(limit: 10, cursor: cursor, status: ["success"])
+    pix_in = Enum.filter(requests, fn(request) -> request.flow == "in" end)
+          |> Enum.filter(fn(request) -> request.amount > 10000 end)
+          |> Enum.take(1)
+
+    get_end_to_end_id_to_reverse(pix_in, cursor)
+  end
+
+  def get_end_to_end_id_to_reverse(pix_request, _cursor) do
+    pix_request
+  end
+
+  def get_end_to_end_id() do
+    pix_request = StarkInfra.PixRequest.query!(limit: 1, status: ["success"]) |> Enum.take(1) |> hd
+    pix_request.end_to_end_id
+  end
+
   def generate_example_pix_reversal() do
-    pix = StarkInfraTest.Utils.EndToEndId.get_end_to_end_id_to_reverse([], nil) |> hd
+    pix = get_end_to_end_id_to_reverse([], nil) |> hd
     %StarkInfra.PixReversal{
       amount: Enum.random(1..10),
       end_to_end_id: pix.end_to_end_id,

test/utils/end_to_end_id.exs

@@ -1,36 +1,5 @@
 defmodule StarkInfraTest.Utils.EndToEndId do
   use ExUnit.Case
 
-  def get_end_to_end_id_to_reverse(pix_request, cursor \\ nil)
-
-  def get_end_to_end_id_to_reverse(pix_request, cursor) when length(pix_request) == 0 do
-    {cursor, requests} = StarkInfra.PixRequest.page!(limit: 10, cursor: cursor, status: ["success"])
-    pix_in = Enum.filter(requests, fn(request) -> request.flow == "in" end)
-          |> Enum.filter(fn(request) -> request.amount > 10000 end)
-          |> Enum.take(1)
-
-    get_end_to_end_id_to_reverse(pix_in, cursor)
-  end
-
-  def get_end_to_end_id_to_reverse(pix_request, _cursor) do
-    pix_request
-  end
-
-  def get_end_to_end_id_to_infraction(pix_request, cursor) when length(pix_request) == 0 do
-    {cursor, requests} = StarkInfra.PixRequest.page!(limit: 10, cursor: cursor, status: ["success"])
-    pix_in = Enum.filter(requests, fn(request) -> request.flow == "out" end)
-          |> Enum.filter(fn(request) -> request.amount > 10000 end)
-          |> Enum.take(1)
-
-    get_end_to_end_id_to_infraction(pix_in, cursor)
-  end
-
-  def get_end_to_end_id_to_infraction(pix_request, _cursor) do
-    pix_request
-  end
-
-  def get_end_to_end_id() do
-    pix_request = StarkInfra.PixRequest.query!(limit: 1, status: ["success"]) |> Enum.take(1) |> hd
-    pix_request.end_to_end_id
-  end
+  
 end