-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't build docker image on M1 macbook #1
Comments
I have the same issue |
I think it's only meant for Linux at the moment |
The docker base image is only available for amd64, the M1 architecture is arm64. You can tweak it to build for arm64, but you will come across with inline assembly that is incompatible, and it will crash while you are trying to build it When you are running it, you are actually running it on a virtualized env (likely qemu) |
@delaaxe @voidcenter @d-roak There will soon be a release that removes the assembly in question, allowing for the docker image to be built on arm64 (I successfully built it on an M1 Mac). |
@delaaxe @voidcenter @d-roak it should now be possible to build the docker on M1 Mac. Please confirm so the issue can be closed. |
@iliav-starkware can you tell me which commit fixed the M1 Mac docker build and what was the change that fixed it? It seems that you are still using inline assembly on some files e.g. |
Just saw the |
@d-roak is it working? |
@iliav-starkware it still fails for me, i'll try again from scratch but full build takes 3h+ on my laptop |
@iliav-starkware tl;dr: no The base image continues to be an amd64 image, so you will build it in a virtualized environment that will take a LONG time to build, and according to @delaaxe, it still fails If u change the base image to one that can build on aarch64, and pass the new |
I confirm still same error |
Good afternoon Guys, You can try to Follow this algorithm! 2)Configure Docker CLI for ARM64: bash bash bash 5)Test the Container: |
Hum.. Chat gpt? |
try chat gpt |
that won't work, i can say it with confidence without trying 😅 |
What blake dependency? Can you elaborate? |
I deleted the repo from my laptop so I can't reproduce it to check the exact error. But there was some error while compiling this file: https://github.com/starkware-libs/stone-prover/blob/main/src/third_party/blake2/blake2s.c But this error is only relevant if you want to port your docker configuration to work both on amd64 and aarch64 natively. Your current approach seems to be working natively on amd64 and virtualized on aarch64, for that I don't know the exact error. @delaaxe might be able to give you more details on that since he tested it |
Closed due to inactivity. |
I didn't follow up on the issue in the latest updates, but if it was not marked as solved, it seems weird to close it due to inactivity. The latest answers were not dismissed with a solution or a won't fix. |
Apologies, the message was intended for another PR. |
Just wanted to add my comments here:
While it's slow, it works. |
Running the command
docker build --tag prover .
fails at the stepRUN ctest -V
:The text was updated successfully, but these errors were encountered: