Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix benchmarks-pages workflow #1012

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

adi-yakovian-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (16293d5) to head (0813801).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1012   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         105      105           
  Lines       14259    14259           
  Branches    14259    14259           
=======================================
  Hits        13241    13241           
  Misses        938      938           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adi-yakovian-starkware adi-yakovian-starkware changed the title chore(ci): add missing cargo-criterion installation chore(ci): fix benchmarks-pages workflow Feb 27, 2025
Copy link

@RoeiE-starkware RoeiE-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adi-yakovian-starkware)

@adi-yakovian-starkware adi-yakovian-starkware merged commit dad3688 into dev Feb 27, 2025
34 checks passed
@adi-yakovian-starkware adi-yakovian-starkware deleted the adi/ci/fix-benchmarks-pages branch February 27, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants