Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-store existing files #60

Open
makew0rld opened this issue Jul 31, 2024 · 1 comment
Open

Don't re-store existing files #60

makew0rld opened this issue Jul 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@makew0rld
Copy link
Contributor

Currently the CID of the file is calculated in the webhook at the same time as the file is being written to disk, for efficiency. But this also means that if the file is overwritten on the disk, even if it's already been stored. Ideally this would not happen.

I'm not sure what the best fix for this is, as calculating the CID of the file in advance would require loading all of it into memory, and would be slow for large files.

This is a pretty minor issue for us for now.

@makew0rld makew0rld added the enhancement New feature or request label Jul 31, 2024
@makew0rld makew0rld self-assigned this Jul 31, 2024
@makew0rld
Copy link
Contributor Author

This was achieved for Browsertrix in #67, since the Browsertrix webhook already gives us a hash that we can compare to the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant