[5.x] Fix whereNotIn error with nulls #13266
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@hastinbe maybe you'd like to run your eyes over this. |
Contributor
I like the solution. I added tests hastinbe@abd91a5 feel free to cherry-pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error described in #13255 is introduced by the conversion to a lookup table in #12894.
The performance improvement was the change to a lookup table.
However if your values contained a null this would fail since you can't have a null key.
This PR maintains the lookup table by replacing
nullwith a placeholder__NULL__string.Fixes #13255