From f12ede7e340ccd88c26209ceecfff2d237120f23 Mon Sep 17 00:00:00 2001
From: Jonas Staudenmeir <mail@jonas-staudenmeir.de>
Date: Thu, 28 Nov 2024 21:48:55 +0100
Subject: [PATCH] Use PHP 8.4 by default (#64)

* Use PHP 8.4 by default

* Exclude Oracle tests
---
 .github/CONTRIBUTING.md               | 6 +++---
 .github/workflows/ci.yml              | 4 +---
 .github/workflows/static-analysis.yml | 2 +-
 docker-compose.ci.yml                 | 8 ++++----
 docker-compose.yml                    | 2 +-
 5 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index dddafe1..49bac33 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -23,7 +23,7 @@ We accept contributions via Pull Requests on [GitHub](https://github.com/stauden
 ## Running Tests & Static Analysis
 
 ```
-docker compose run --rm php8.3 composer install
-docker compose run --rm php8.3 vendor/bin/phpunit
-docker compose run --rm php8.3 vendor/bin/phpstan analyse --memory-limit=-1
+docker compose run --rm php8.4 composer install
+docker compose run --rm php8.4 vendor/bin/phpunit
+docker compose run --rm php8.4 vendor/bin/phpstan analyse --memory-limit=-1
 ```
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e668937..725ba91 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,10 +18,8 @@ jobs:
         exclude:
           - php: 8.4
             database: oracle
-          - php: 8.4
-            database: firebird
         include:
-          - php: 8.3
+          - php: 8.4
             release: stable
             coverage: true
 
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
index f7110d1..467d919 100644
--- a/.github/workflows/static-analysis.yml
+++ b/.github/workflows/static-analysis.yml
@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        php: [ 8.3 ]
+        php: [ 8.4 ]
         release: [ stable ]
 
     steps:
diff --git a/docker-compose.ci.yml b/docker-compose.ci.yml
index ebe7613..54ecae9 100644
--- a/docker-compose.ci.yml
+++ b/docker-compose.ci.yml
@@ -15,20 +15,20 @@ services:
     volumes:
       - .:/var/www/html:delegated
       - ~/.cache/composer/files:/root/.composer/cache/files
-  php8.3-xdebug:
-    image: ghcr.io/staudenmeir/php:8.3
+  php8.4:
+    image: ghcr.io/staudenmeir/php:8.4
     working_dir: /var/www/html
     networks:
       - test
     volumes:
       - .:/var/www/html:delegated
-      - .docker/xdebug.ci.ini:/usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
       - ~/.cache/composer/files:/root/.composer/cache/files
-  php8.4:
+  php8.4-xdebug:
     image: ghcr.io/staudenmeir/php:8.4
     working_dir: /var/www/html
     networks:
       - test
     volumes:
       - .:/var/www/html:delegated
+      - .docker/xdebug.ci.ini:/usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
       - ~/.cache/composer/files:/root/.composer/cache/files
diff --git a/docker-compose.yml b/docker-compose.yml
index 1119a46..27e79af 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -22,7 +22,7 @@ services:
       - test
     volumes:
       - .:/var/www/html:delegated
-      #- .docker/xdebug.ini:/usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
+      - .docker/xdebug.ini:/usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
   mysql:
     image: 'mysql:latest'
     environment: