Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Multiline editing is broken in the REPL #4970

Open
2 tasks done
Snehil-Shah opened this issue Jan 30, 2025 · 1 comment
Open
2 tasks done

[BUG]: Multiline editing is broken in the REPL #4970

Snehil-Shah opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.

Comments

@Snehil-Shah
Copy link
Member

Snehil-Shah commented Jan 30, 2025

Description

After keybindings, some multiline editing features like continuous backspaces into the previous line and moving back to the previous line using left arrow, is broken. It's because we are intercepting these keys in the editor actions itself.

Also when the completer tab is on, backspace is acting twice, I believe for the same reason.

This will be fixed when we add the ability to configure existing actions (like the multiline actions itself), where we'll club the logic of backspaces, left arrows, and right arrows in one place.

Related Issues

Related issues #2647 .

Questions

No.

Demo

No response

Reproduction

  • Try to hit backspace or left arrow when at the beginning of a line, in a multiline input.

Expected Results

It should go back to the previous line.

Actual Results

Doesn't go back to the previous line.

Environments

Node.js

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@Snehil-Shah Snehil-Shah added the REPL Issue or pull request specific to the project REPL. label Jan 30, 2025
@Snehil-Shah Snehil-Shah self-assigned this Jan 30, 2025
@kgryte kgryte added the Bug Something isn't working. label Jan 31, 2025
@kgryte
Copy link
Member

kgryte commented Jan 31, 2025

Thanks for reporting this, @Snehil-Shah. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Development

No branches or pull requests

2 participants