[BUG]: C implementation for stats/base/dists/kumaraswamy/median has different results than the JavaScript implementation

[anandkaranubc]

Description

Pointed out by @Neerajpathak07 and @yuvi-mittal

For context, see comment

When running native tests for stats/base/dists/kumaraswamy/median, the majority of tests fail because the C implementation is generalized for a single value of a = 1.0 rather than any positive number.

The fix is to change

stdlib/lib/node_modules/@stdlib/stats/base/dists/kumaraswamy/median/src/main.c

Line 42 in 367ec2c

return 1.0 - stdlib_base_pow( 0.5, 1.0 / b );

to:

return stdlib_base_pow( 1.0 - stdlib_base_pow( 2.0, -1.0 / b ), 1.0 / a );

Related Issues

None

Questions

No.

Demo

No response

Reproduction

- Run `make install-node-addons NODE_ADDONS_PATTERN="stats/base/dists/kumaraswamy/median"`
- Run `make test TESTS_FILTER=".*/stats/base/dists/kumaraswamy/median/test/test.native.js"`

Expected Results

total:     1009
passing:   1009

Actual Results

total:     1009
passing:   27
failing:   982

Version

No response

Environments

N/A

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

• Read and understood the Code of Conduct.
• Searched for existing issues and pull requests.

[anandkaranubc]

@Neerajpathak07, do you want to proceed with a PR targeting this issue?

[kgryte]

There were a lot of issues with the PR adding the C implementation which were missed during code review. See fc5df17. Someone should take a close look at that package to determine whether everything is correct.

cc @Planeshifter

[kgryte]

Also, the tests in test.native.js still don't fully match what is in test.js.

[anandkaranubc]

Someone should take a close look at that package to determine whether everything is correct.

I will take a detailed look and update this issue. If it turns out to be a major change, I will likely create a PR to address it.

[Neerajpathak07]

@Neerajpathak07, do you want to proceed with a PR targeting this issue?

Ig @yuvi-mittal has started working upon it after I pointed out what was wrong.

[yuvi-mittal]

I have already started working on it , and i have been checking rest of the distributions too , there are few test cases more that are failing , will raise a PR soon.

[anandkaranubc]

@yuvi-mittal Any updates on this :)

[yuvi-mittal]

@anandkaranubc , hey i have been swamped with some college work ,i will get it done before eow.

[anandkaranubc]

@anandkaranubc , hey i have been swamped with some college work ,i will get it done before eow.

No rush! Just wanted to check in to see if you needed any help. Good luck with your work!