Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve EditorConfig lint errors #5220

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #5156.

Description

What is the purpose of this pull request?

This pull request:

  • Resolve lint error acc to Editorconfig

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 14, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Feb 14, 2025

@Planeshifter One more Thing sir , you should review tools/docs/jsdoc/templates/html/publish.js it has too many error on commit .

@saurabhraghuvanshii
Copy link
Contributor Author

/stdlib-help

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Feb 14, 2025
@@ -21,8 +21,8 @@ Usage: TODO [options]

Options:

-h, --help Print this message.
-V, --version Print the package version.
-h, --help Print this message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not desired.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file there error of license header missing.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 16, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

I do all of this because on running command ec for checking EditorConfig these file violate indetation some have tab some's have spaces so therefore I changes this

@kgryte
Copy link
Member

kgryte commented Feb 16, 2025

@saurabhraghuvanshii Notice our configuration: https://github.com/stdlib-js/stdlib/blob/develop/etc/editorconfig-checker/.editorconfig_checker.json

@kgryte
Copy link
Member

kgryte commented Feb 16, 2025

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@saurabhraghuvanshii saurabhraghuvanshii changed the title chore: Resolve EditorConfig lint errors chore: resolve EditorConfig lint errors Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue: Resolve EditorConfig lint errors
3 participants