Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write doesn't fail if the wrong type is passed #263

Open
DantePuglisi opened this issue May 16, 2022 · 1 comment · May be fixed by #264
Open

Write doesn't fail if the wrong type is passed #263

DantePuglisi opened this issue May 16, 2022 · 1 comment · May be fixed by #264

Comments

@DantePuglisi
Copy link

Summary:
There's no way to know if a characteristic has the specified CBCharacteristicWriteType when calling write because if it doesn't, success is returned instead of fail.

Steps to Reproduce:

  1. Call bluejay.write passing a CharacteristicIdentifier and either .withResponse or .withoutResponse as its type (pass the one that doesn't correspond to what that characteristic has as its writeProperty).

Actual Result:
Callback from write is success even if the wrong CBCharacteristicWriteType is passed.

Expected Result:
Callback from write should be fail if the wrong CBCharacteristicWriteType is passed.

Device, Build, OS:
iPhone 13 Pro - iOS 15.4.1
@DantePuglisi DantePuglisi linked a pull request May 16, 2022 that will close this issue
Open
@DantePuglisi
Copy link
Author

Just pushed a Pull Request to fix this #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make WriteCharacteristic fail if types mismatch DantePuglisi/bluejay
1 participant
@DantePuglisi