Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Photo Support #121

Closed
steilerDev opened this issue Dec 18, 2022 · 7 comments
Closed

Live Photo Support #121

steilerDev opened this issue Dec 18, 2022 · 7 comments
Labels
class(feature) Indicates work related to a new feature status(backlog) This item is considered for future development

Comments

@steilerDev
Copy link
Owner

steilerDev commented Dec 18, 2022

Syncing Live Photo's video portion as a separate file.

@steilerDev steilerDev added the status(backlog) This item is considered for future development label Dec 18, 2022
@steilerDev steilerDev added this to the v2.0.0 milestone Dec 18, 2022
@steilerDev steilerDev added next and removed status(backlog) This item is considered for future development labels Jan 4, 2023
@steilerDev steilerDev added status(backlog) This item is considered for future development and removed next labels Feb 17, 2023
@steilerDev steilerDev modified the milestones: v2.0.0, v1.1.0 Mar 10, 2023
@steilerDev steilerDev added next and removed status(backlog) This item is considered for future development labels Mar 12, 2023
@steilerDev steilerDev modified the milestones: v2.0.0, v1.2.0 Mar 12, 2023
@steilerDev steilerDev added class(feature) Indicates work related to a new feature and removed next labels Mar 19, 2023
@steilerDev steilerDev removed this from the v1.2.0 milestone Jul 4, 2023
@steilerDev steilerDev added the status(backlog) This item is considered for future development label Jul 4, 2023
@mzaferyahsi
Copy link

I would love to help you on this one. I've looked at the postman collection and I think I found the live video, which is at resOriginalVidComplRes I believe. For HEIC, I don't see the sidecar file though, do you know where that is located?

@steilerDev
Copy link
Owner Author

I'm not sure if this is available through the API - why would the sidecar file be important?

@steilerDev
Copy link
Owner Author

I have some comments across the code where changes need to happen for this. Generally speaking loading the local and remote library needs to support this.

@steilerDev
Copy link
Owner Author

I had a think about this, and other future additional assets associated to a picture - we should consider using an extensible container format for storing those assets in a single location.

A couple of options I've been investigating:

  • Have a directory per picture, with different versions (original, edited, live, ...) in there
  • Use a standardized container format, like TIFF or matrovska - however it seems none of them supports both video and images. Matrovska is very much focused on audio and video, while tiff only seems to support pictures

I'm a little bit torn between the options and would love to have your opinion on this

@mzaferyahsi
Copy link

I'm not sure if this is available through the API - why would the sidecar file be important?

I am using PhotoSync and it provides the adjustment data if the image is adjusted, and some of my photos are.

I had a think about this, and other future additional assets associated to a picture - we should consider using an extensible container format for storing those assets in a single location.

A couple of options I've been investigating:

  • Have a directory per picture, with different versions (original, edited, live, ...) in there
  • Use a standardized container format, like TIFF or matrovska - however it seems none of them supports both video and images. Matrovska is very much focused on audio and video, while tiff only seems to support pictures

I'm a little bit torn between the options and would love to have your opinion on this

The preference I have would be to have the additional files with the same name and since they will differ on file type, it should not be an issue. At least PhotoSync does it that way and would be nice to keep it consistent. Having a separate folder per image would create a management hell in my opinion. In terms of a container format, I haven't seen anything that would be able to cover the set of files in this case.

@steilerDev
Copy link
Owner Author

I've created a separate issue (#354) to explain my proposal - would love to get your input on my ideas there / alternative ideas.

For the sidecar files - if the API allows me to pull them I'm happy to work them into the new library structure - if we add many additional files without separating them in folders, the folders themselve could become very cluttered, very quickly - we need to find a good balance.

@steilerDev
Copy link
Owner Author

Closing this in favor of #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class(feature) Indicates work related to a new feature status(backlog) This item is considered for future development
Projects
No open projects
Development

No branches or pull requests

2 participants