Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Consistency check #291

Closed
lonevvolf opened this issue Jul 9, 2023 · 2 comments
Closed

Feature Request: Consistency check #291

lonevvolf opened this issue Jul 9, 2023 · 2 comments
Labels
class(feature) Indicates work related to a new feature status(help needed) Help from other people is necessary to resolve this issue

Comments

@lonevvolf
Copy link

Describe the feature

I have a large library with other 300k photos. During syncing, I occasionally got breaks in the process which resulted in having to force unlock. I have a concern that maybe some larger videos, etc. may not be transferred completely. It would be interesting to run a consistency check on all files to ensure they match the server versions. Is this done automatically in some way? Since I imagine this can take a long time with so many files, maybe it needs a dedicated command?

@steilerDev
Copy link
Owner

steilerDev commented Jul 9, 2023

When syncing the library I am loading all local assets, by reading the files. This is done by looking at the creation time and size (not the content).

Apple provides 'checksum' field within the API, but I have yet to figure out how to calculate this checksum - this would provide a really reliable consistency check, unfortunately I'm out of ideas.

On the library lock errors: This is a very simple locking logic, that was implemented to make sure that two instances of the sync engine are not accessing the file system at the same time - if you are sure no other instance runs, it's safe to remove the lock manually.

@steilerDev steilerDev added status(help needed) Help from other people is necessary to resolve this issue class(feature) Indicates work related to a new feature labels Jul 9, 2023
@steilerDev
Copy link
Owner

I've created a separate issue (#354) to explain my proposal for a new library version that should resolve this issue. Would therefore love to get your feedback on there and going to close this issue for now. Please re-open if you don't think it is covered by this initiative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class(feature) Indicates work related to a new feature status(help needed) Help from other people is necessary to resolve this issue
Projects
None yet
Development

No branches or pull requests

2 participants