Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in glyphBBoxes section of Petaluma.json (with "fontVersion": 1.12) #9

Open
ccianflone opened this issue Mar 16, 2021 · 0 comments

Comments

@ccianflone
Copy link

In processing json metadata and reading the glyphBBoxes data, one step that needs to happen is to get a codepoint for the named glyph, and that can either come from standard names in the standard glyphnames.json file, or in the optionalGlyphs section of the font’s json metadata file. In that lookup process, it is of course important that the names from glyphBBoxes are found in one of these locations, and that the names match exactly. Running some tests over our current list of SMuFL fonts found the following problems in Petaluma.json:

In json file: Petaluma.json, missing character: braceflat
In json file: Petaluma.json, missing character: bracelarge
In json file: Petaluma.json, missing character: bracelarger
In json file: Petaluma.json, missing character: bracesmall
Looks like this is simply a problem with character case, should be:
braceFlat
braceLarge
braceLarger
braceSmall

In json file: Petaluma.json, missing character: csymAugmentedSmall.augmentedsmall
In json file: Petaluma.json, missing character: csymDiminishedSmall.dim7
In json file: Petaluma.json, missing character: csymMajorSeventhSmall.maj7
In json file: Petaluma.json, missing character: csymMinorSmall.minorsmall
I think these are just typos, and should just be:
csymAugmentedSmall
csymDiminishedSmall
csymMajorSeventhSmall
csymMinorSmall

In json file: Petaluma.json, missing character: null
is this supposed to be noteheadNull?, not sure since both noteheadNull and null are found in glyphBBoxes, and not found anywhere else
In json file: Petaluma.json, missing character: spa
possibly space?

The brace_ and csym_ issues look like pretty straight-forward errors to fix. Not sure what is intended with null and spa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant