refactor: use t.TempDir() instead of os.MkdirTemp (#5620)

Signed-off-by: laterlaugh <manziwenzhai@sina.cn>

Author: laterlaugh

ingest/ledgerbackend/captive_core_backend_test.go

@@ -6,15 +6,13 @@ import (
 	"fmt"
 	"net/http"
 	"net/http/httptest"
-	"os"
 	"sync"
 	"testing"
 
 	"github.com/prometheus/client_golang/prometheus"
 	dto "github.com/prometheus/client_model/go"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
-	"github.com/stretchr/testify/require"
 
 	"github.com/stellar/go/historyarchive"
 	"github.com/stellar/go/network"
@@ -138,9 +136,7 @@ type testLedgerHeader struct {
 }
 
 func TestCaptiveNew(t *testing.T) {
-	storagePath, err := os.MkdirTemp("", "captive-core-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(storagePath)
+	storagePath := t.TempDir()
 
 	var userAgent string
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -173,9 +169,7 @@ func TestCaptiveNew(t *testing.T) {
 }
 
 func TestCaptiveNewUnsupportedProtocolVersion(t *testing.T) {
-	storagePath, err := os.MkdirTemp("", "captive-core-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(storagePath)
+	storagePath := t.TempDir()
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusOK)
@@ -186,7 +180,7 @@ func TestCaptiveNewUnsupportedProtocolVersion(t *testing.T) {
 	networkPassphrase := network.PublicNetworkPassphrase
 	historyURLs := []string{server.URL}
 
-	_, err = NewCaptive(
+	_, err := NewCaptive(
 		CaptiveCoreConfig{
 			BinaryPath:            executablePath,
 			NetworkPassphrase:     networkPassphrase,
@@ -1022,9 +1016,7 @@ func TestCaptiveGetLedger_NextLedger0RangeFromIsSmallerThanLedgerFromBuffer(t *t
 }
 
 func TestCaptiveStellarCore_PrepareRangeAfterClose(t *testing.T) {
-	storagePath, err := os.MkdirTemp("", "captive-core-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(storagePath)
+	storagePath := t.TempDir()
 
 	ctx := context.Background()
 	executablePath := "/etc/stellar-core"

ingest/ledgerbackend/file_watcher_test.go

@@ -3,15 +3,13 @@ package ledgerbackend
 import (
 	"context"
 	"fmt"
-	"os"
 	"sync"
 	"testing"
 	"time"
 
 	"github.com/stellar/go/support/log"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 type mockHash struct {
@@ -45,9 +43,7 @@ func (m *mockHash) hashFile(fp string) (hash, error) {
 }
 
 func createFWFixtures(t *testing.T) (*mockHash, *stellarCoreRunner, *fileWatcher) {
-	storagePath, err := os.MkdirTemp("", "captive-core-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(storagePath)
+	storagePath := t.TempDir()
 
 	ms := &mockHash{
 		hashResult:   hash{},
@@ -75,9 +71,7 @@ func createFWFixtures(t *testing.T) (*mockHash, *stellarCoreRunner, *fileWatcher
 }
 
 func TestNewFileWatcherError(t *testing.T) {
-	storagePath, err := os.MkdirTemp("", "captive-core-*")
-	require.NoError(t, err)
-	defer os.RemoveAll(storagePath)
+	storagePath := t.TempDir()
 
 	ms := &mockHash{
 		hashResult:   hash{},