From a1ac23a2d3b9c13daed13fa46fc45b5baabf6f29 Mon Sep 17 00:00:00 2001
From: Morley Zhi <morley@stellar.org>
Date: Tue, 7 Jan 2020 16:26:44 -0500
Subject: [PATCH] fix test; fix facade semantics

---
 src/plugins/LocalStorageFacade.ts     |  9 +++--
 src/transfers/DepositProvider.test.ts | 52 +++++++++++++++------------
 2 files changed, 37 insertions(+), 24 deletions(-)

diff --git a/src/plugins/LocalStorageFacade.ts b/src/plugins/LocalStorageFacade.ts
index cf529675..7a4e4447 100644
--- a/src/plugins/LocalStorageFacade.ts
+++ b/src/plugins/LocalStorageFacade.ts
@@ -10,8 +10,13 @@ export interface LocalStorageConfigParams {
  * local storage
  */
 export class LocalStorageFacade {
-  private storage: Storage | null = null;
-  private prefix: string = "stellarkeys";
+  private storage: Storage | null;
+  private prefix: string;
+
+  constructor() {
+    this.storage = null;
+    this.prefix = "stellarkeys";
+  }
 
   public configure(params: LocalStorageConfigParams) {
     Object.assign(this, params);
diff --git a/src/transfers/DepositProvider.test.ts b/src/transfers/DepositProvider.test.ts
index d5570739..7e1acd7f 100644
--- a/src/transfers/DepositProvider.test.ts
+++ b/src/transfers/DepositProvider.test.ts
@@ -92,28 +92,36 @@ describe("watchOneTransaction", () => {
   // suite-wide consts
   const transferServer = "https://www.stellar.org/transfers";
 
-  const pendingTransaction = (n: number = 0): Transaction => {
+  const pendingTransaction = (n: number = 0): { transaction: Transaction } => {
     return {
-      kind: "deposit",
-      id: "TEST",
-      status: TransactionStatus.pending_anchor,
-      status_eta: n,
+      transaction: {
+        kind: "deposit",
+        id: "TEST",
+        status: TransactionStatus.pending_anchor,
+        status_eta: n,
+      },
     };
   };
-  const successfulTransaction = (n: number = 0): Transaction => {
+  const successfulTransaction = (
+    n: number = 0,
+  ): { transaction: Transaction } => {
     return {
-      kind: "deposit",
-      id: "TEST",
-      status: TransactionStatus.completed,
-      status_eta: n,
+      transaction: {
+        kind: "deposit",
+        id: "TEST",
+        status: TransactionStatus.completed,
+        status_eta: n,
+      },
     };
   };
-  const failedTransaction = (n: number = 0): Transaction => {
+  const failedTransaction = (n: number = 0): { transaction: Transaction } => {
     return {
-      kind: "deposit",
-      id: "TEST",
-      status: TransactionStatus.error,
-      status_eta: n,
+      transaction: {
+        kind: "deposit",
+        id: "TEST",
+        status: TransactionStatus.error,
+        status_eta: n,
+      },
     };
   };
 
@@ -156,7 +164,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -190,7 +198,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -224,7 +232,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -263,7 +271,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -315,7 +323,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -375,7 +383,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,
@@ -436,7 +444,7 @@ describe("watchOneTransaction", () => {
     // start watching
     provider.watchOneTransaction({
       asset_code: "SMX",
-      id: successfulTransaction(0).id,
+      id: successfulTransaction(0).transaction.id,
       onMessage,
       onSuccess,
       onError,