diff --git a/search-service/config/detekt/baseline.xml b/search-service/config/detekt/baseline.xml index 354131c82..6dea7ba08 100644 --- a/search-service/config/detekt/baseline.xml +++ b/search-service/config/detekt/baseline.xml @@ -4,9 +4,7 @@ ClassNaming:V0_29_JsonLd_migrationTests.kt$V0_29_JsonLd_migrationTests ClassNaming:V0_29__JsonLd_migration.kt$V0_29__JsonLd_migration : BaseJavaMigration - ComplexCondition:EntitiesQueryUtils.kt$geoQuery == null && q.isNullOrEmpty() && - typeSelection.isNullOrEmpty() && attrs.isEmpty() && local != true - + ComplexCondition:EntitiesQueryUtils.kt$geoQuery == null && q.isNullOrEmpty() && typeSelection.isNullOrEmpty() && attrs.isEmpty() && local != true Filename:V0_29__JsonLd_migration.kt$db.migration.V0_29__JsonLd_migration.kt LongMethod:AttributeInstanceService.kt$AttributeInstanceService$@Transactional suspend fun create(attributeInstance: AttributeInstance): Either<APIException, Unit> LongMethod:EnabledAuthorizationServiceTests.kt$EnabledAuthorizationServiceTests$@Test fun `it should return serialized access control entities with other rigths if user is owner`() @@ -21,11 +19,7 @@ LongParameterList:AttributeInstance.kt$AttributeInstance.Companion$( attributeUuid: UUID, instanceId: URI = generateRandomInstanceId(), timeAndProperty: Pair<ZonedDateTime, TemporalProperty>, value: Triple<String?, Double?, WKTCoordinates?>, payload: ExpandedAttributeInstance, sub: String? ) LongParameterList:AttributeInstance.kt$AttributeInstance.Companion$( attributeUuid: UUID, instanceId: URI = generateRandomInstanceId(), timeProperty: TemporalProperty? = TemporalProperty.OBSERVED_AT, modifiedAt: ZonedDateTime? = null, attributeMetadata: AttributeMetadata, payload: ExpandedAttributeInstance, time: ZonedDateTime, sub: String? = null ) LongParameterList:BusinessObjectsFactory.kt$( attributeUuid: UUID, timeProperty: AttributeInstance.TemporalProperty = AttributeInstance.TemporalProperty.OBSERVED_AT, measuredValue: Double? = Random.nextDouble(), value: String? = null, time: ZonedDateTime = ngsiLdDateTime(), sub: Sub? = null ) - LongParameterList:EntitiesQuery.kt$EntitiesQuery$( open val q: String?, open val scopeQ: String?, open val - paginationQuery: PaginationQuery, open val attrs: Set<ExpandedTerm>, open val datasetId: Set<String>, - open val geoQuery: GeoQuery?, open val linkedEntityQuery: LinkedEntityQuery?, open val local: Boolean?, open val - contexts: List<String> ) - + LongParameterList:EntitiesQuery.kt$EntitiesQuery$( open val q: String?, open val scopeQ: String?, open val paginationQuery: PaginationQuery, open val attrs: Set<ExpandedTerm>, open val datasetId: Set<String>, open val geoQuery: GeoQuery?, open val linkedEntityQuery: LinkedEntityQuery?, open val local: Boolean?, open val contexts: List<String> ) LongParameterList:EntityAttributeService.kt$EntityAttributeService$( attribute: Attribute, attributeName: ExpandedTerm, attributeMetadata: AttributeMetadata, mergedAt: ZonedDateTime, observedAt: ZonedDateTime?, attributePayload: ExpandedAttributeInstance, sub: Sub? ) LongParameterList:EntityAttributeService.kt$EntityAttributeService$( attribute: Attribute, ngsiLdAttribute: NgsiLdAttribute, attributeMetadata: AttributeMetadata, createdAt: ZonedDateTime, attributePayload: ExpandedAttributeInstance, sub: Sub? ) LongParameterList:EntityAttributeService.kt$EntityAttributeService$( entityId: URI, attributeName: ExpandedTerm, attributeMetadata: AttributeMetadata, createdAt: ZonedDateTime, attributePayload: ExpandedAttributeInstance, sub: Sub? ) diff --git a/search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt b/search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt index 2d4261ba8..11119ff7f 100644 --- a/search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt +++ b/search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt @@ -43,13 +43,13 @@ open class CSRFilters( // we should use a combination of EntitiesQuery TemporalQ ) companion object { - fun fromQueryParameter( - queryParams: MultiValueMap, + fun fromQueryParameters( + queryParameters: MultiValueMap, contexts: List ): Either = either { - val ids = queryParams.getFirst(QueryParameter.ID.key)?.split(",").orEmpty().toListOfUri().toSet() - val typeSelection = expandTypeSelection(queryParams.getFirst(QueryParameter.TYPE.key), contexts) - val idPattern = validateIdPattern(queryParams.getFirst(QueryParameter.ID_PATTERN.key)).bind() + val ids = queryParameters.getFirst(QueryParameter.ID.key)?.split(",").orEmpty().toListOfUri().toSet() + val typeSelection = expandTypeSelection(queryParameters.getFirst(QueryParameter.TYPE.key), contexts) + val idPattern = validateIdPattern(queryParameters.getFirst(QueryParameter.ID_PATTERN.key)).bind() CSRFilters(ids = ids, typeSelection = typeSelection, idPattern = idPattern) } diff --git a/search-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt b/search-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt index d9e6e6b4c..fbf96be1e 100644 --- a/search-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt +++ b/search-service/src/main/kotlin/com/egm/stellio/search/csr/web/ContextSourceRegistrationHandler.kt @@ -102,7 +102,7 @@ class ContextSourceRegistrationHandler( ): ResponseEntity<*> = either { val contexts = getContextFromLinkHeaderOrDefault(httpHeaders, applicationProperties.contexts.core).bind() val mediaType = getApplicableMediaType(httpHeaders).bind() - val csrFilters = CSRFilters.fromQueryParameter(queryParams, contexts).bind() + val csrFilters = CSRFilters.fromQueryParameters(queryParams, contexts).bind() val includeSysAttrs = queryParams.getOrDefault(QueryParameter.OPTIONS.key, emptyList()) .contains(OptionsValue.SYS_ATTRS.value)