Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate presentation of sense restrictions #76

Open
stephenmk opened this issue Feb 12, 2024 Discussed in #74 · 5 comments
Open

Reevaluate presentation of sense restrictions #76

stephenmk opened this issue Feb 12, 2024 Discussed in #74 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@stephenmk
Copy link
Owner

Discussed in #74

Originally posted by parfait8566 February 10, 2024
For example, the entry "十戒" currently looks like this:

  • 1st sense〔十戒 only〕
  • 2nd sense

I think it would be immediately clearer if the restriction information was shown more like this:

  • 1st sense 〔十戒〕
  • 2nd sense〔十戒・十誡〕

I guess it could look awkward if there are a ton of possible forms/readings for the same sense, but wouldn't it be possible to make it that if they exceed a certain number they revert to the previous look?

@stephenmk stephenmk added the enhancement New feature or request label Feb 12, 2024
@stephenmk stephenmk self-assigned this Feb 12, 2024
@stephenmk
Copy link
Owner Author

Hmm... it would be cool if I could integrate the sense restrictions into the forms table.

A couple mockups

gunsei
jikkai

@parfait8566
Copy link

How would this work with e.g. a form that applies to multiple senses but not all?

I'm going to propose an edit for 十戒, as JMdict generally seems to be more partial to notes. I personally prefer restrictions, but I guess they're unpopular.
I still like the "system" I originally proposed, I think that some kokugos occasionally use something similar (like Meikyo for 群生).

@stephenmk
Copy link
Owner Author

stephenmk commented Oct 23, 2024

How would this work with e.g. a form that applies to multiple senses but not all?

Tell me if I'm crazy. I think I prefer right/bottom over left/top.

ばね left ばね right
bane2 bane
じっかい top じっかい bottom
jikkai2 jikkai1

I'm going to propose an edit for 十戒, as JMdict generally seems to be more partial to notes.

That's the direction we're going in, and that's probably best for most apps that use jmdict data. It makes it difficult for me to do things that I think are cool, though.

@stephenmk
Copy link
Owner Author

stephenmk commented Oct 23, 2024

The more I think about this setup, the more I like it. I think I'm gonna go ahead and implement it.

Sometimes the results will be a little difficult to understand, but I think that's only when the data itself is difficult to understand. For example, in the entry for よんど, 4°【しど】 doesn't technically apply to any of the senses. I think it's easier to see this through the table approach at least.

Before After
yondo2 yondo

I should probably check the intersection of these sense restrictions and remove the ◇ symbol if the result is empty.

@parfait8566
Copy link

Tell me if I'm crazy. I think I prefer right/bottom over left/top.
ばね left ばね right
bane2 bane
じっかい top じっかい bottom
jikkai2 jikkai1

That's actually pretty neat. I personally prefer right/top. Though with restrictions on the top the two empty rows on the left look a bit awkward.

That's the direction we're going in, and that's probably best for most apps that use jmdict data. It makes it difficult for me to do things that I think are cool, though.

Wouldn't it be technically possible to systematically convert notes into normal restrictions? They usually follow the same format ("occ. written as", "also written as", etc.). Maybe too outlandish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants