Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to remove a loop edge makes stinger go into an infinite loop #5

Open
rohitvarkey opened this issue Oct 19, 2016 · 1 comment

Comments

@rohitvarkey
Copy link
Collaborator

using StingerWrapper
s = Stinger()
insert_edge!(s, 0, 1, 1, 0, 0)
remove_edge!(s, 0, 1, 1) #Goes into infinite loop

The C definition of remove_edge! does have a note specifying how this function should not be called concurrently with the same source.

@jpfairbanks Does this case come under that condition? I guess we should add a check for this at the wrapper side (in remove_edge) in any case.

If we are not able to allow for deletion of loop edges, should we allow such an edge to be inserted in insert_edge! in the first place?

@jpfairbanks
Copy link
Collaborator

I think the consensus is that self edges are not supported by stinger. So the julia side should just check on insertion and deletion to prevent calling into stinger when src==dst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants