Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning for threads #106

Open
stonier opened this issue Aug 28, 2020 · 0 comments · May be fixed by stonier/ecl_tools#12
Open

Build warning for threads #106

stonier opened this issue Aug 28, 2020 · 0 comments · May be fixed by stonier/ecl_tools#12
Assignees
Milestone

Comments

@stonier
Copy link
Owner

stonier commented Aug 28, 2020

From this github action for kobuki.

  The package name passed to `find_package_handle_standard_args` (Threads)
  does not match the name of the calling package (ecl_threads).  This can
  lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.

occuring whenever find_package(ecl_threads) is called. Can't reproduce locally - the github action is using a custom installed 3.17 version of cmake in /usr/local, whereas the official release for ubuntu 20.04 is v3.16.

Not urgent (seems to be just providing guidance to adhere to capitalisation in names more strictly), wait till I have a v3.17+ available so I can reproduce locally.

@stonier stonier self-assigned this Aug 28, 2020
@stonier stonier modified the milestones: Foxy, ToDo Aug 28, 2020
@clalancette clalancette linked a pull request Oct 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant