Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security issue] @stoplight/elements still relies on @sentry/browser@6.19.7 #2735

Open
thomas-spinergie opened this issue Nov 18, 2024 · 1 comment
Labels
jira p/medium security Pull requests that address a security vulnerability triaged

Comments

@thomas-spinergie
Copy link

thomas-spinergie commented Nov 18, 2024

Context

Hi,

I have a security/dependabot issue opened when I use the latest @stoplight/elements regarding the usage of @sentry/browser@6.19.7.

I can see this dependency has been dropped (which is great):
#2720
stoplightio/react-error-boundary@e63e982

But still it looks it remains an issue

Current Behavior

When I do yarn add @stoplight/elements it also keep installing the @stoplight/react-error-boundary@2.0.0 (additionally to the v3.0.0) which itself depends on @sentry/browser. I did a yarn why to detect where it come from:

yarn why @stoplight/react-error-boundary
yarn why v1.22.22
[1/4] Why do we have the module "@stoplight/react-error-boundary"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "@stoplight/react-error-boundary@2.0.0"
info Has been hoisted to "@stoplight/react-error-boundary"
info Reasons this module exists
   - Hoisted from "@stoplight#elements#@stoplight#elements-core#@stoplight#json-schema-viewer#@stoplight#react-error-boundary"
   - Hoisted from "@stoplight#elements#@stoplight#elements-core#@stoplight#markdown-viewer#@stoplight#react-error-boundary"

It seems that @stoplight#elements#@stoplight#elements-core#@stoplight#json-schema-viewer and @stoplight#elements#@stoplight#elements-core#@stoplight#markdown-viewer needs to force resolution to use as well @stoplight/react-error-boundary@3.0.0 ?

Expected Behavior

@sentry/browser@6.19.7 and @stoplight/react-error-boundary@2.0.0 shouldn't be installed anymore when using the latest of @stoplight/elements.

Possible Workaround/Solution

  • Upgrade resolutions for json-schema-viewer and markdown-viewer ?

Steps to Reproduce

  • yarn add @stoplight/elements and yarn why @stoplight/react-error-boundary
@thomas-spinergie thomas-spinergie changed the title @stoplight/elements still relies on @sentry/browser@6.19.7 [Security issue] @stoplight/elements still relies on @sentry/browser@6.19.7 Nov 18, 2024
@mnaumanali94 mnaumanali94 added jira p/medium security Pull requests that address a security vulnerability labels Nov 22, 2024
Copy link

This ticket has been labeled jira. A tracking ticket in Stoplight's Jira (PROVCON-3125) has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira p/medium security Pull requests that address a security vulnerability triaged
Projects
None yet
Development

No branches or pull requests

2 participants