From 270f30cada519dbacbd856335aa3da23c0842490 Mon Sep 17 00:00:00 2001 From: Christopher Ayling Date: Fri, 7 Feb 2025 11:19:12 -0500 Subject: [PATCH 1/2] thow error if no file found to lint --- packages/cli/src/services/__tests__/linter.test.ts | 6 ++++++ packages/cli/src/services/linter/linter.ts | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/cli/src/services/__tests__/linter.test.ts b/packages/cli/src/services/__tests__/linter.test.ts index 19da4a16c..cb6f8e760 100644 --- a/packages/cli/src/services/__tests__/linter.test.ts +++ b/packages/cli/src/services/__tests__/linter.test.ts @@ -97,6 +97,12 @@ describe('Linter service', () => { ); }); + it('demands a file to be present', () => { + return expect(run('lint -r ./gh-474/ruleset.js ./gh-474/does-not-exist.json')).rejects.toThrow( + 'No files found to lint. Please check your file path and extension and try again', + ); + }); + describe('when document is local file', () => { describe('and the file is expected to have no warnings', () => { it('outputs no issues', () => { diff --git a/packages/cli/src/services/linter/linter.ts b/packages/cli/src/services/linter/linter.ts index aaaf19d9c..4d868f36a 100644 --- a/packages/cli/src/services/linter/linter.ts +++ b/packages/cli/src/services/linter/linter.ts @@ -39,7 +39,12 @@ export async function lint(documents: Array, flags: ILintConfig } } - for (const targetUri of [...targetUris, ...fileDescriptors]) { + const targets = [...targetUris, ...fileDescriptors]; + if (targetUris.length === 0) { + throw new CLIError(`No files found to lint. Please check your file path and extension and try again`); + } + + for (const targetUri of targets) { if (flags.verbose === true) { console.info(`Linting ${targetUri}`); } From 5d7f3770101578b5649ea307ea9ecde7efc13e11 Mon Sep 17 00:00:00 2001 From: Christopher Ayling Date: Tue, 11 Feb 2025 07:42:00 -0500 Subject: [PATCH 2/2] check targets for length --- packages/cli/src/services/linter/linter.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/services/linter/linter.ts b/packages/cli/src/services/linter/linter.ts index 4d868f36a..11cb0a082 100644 --- a/packages/cli/src/services/linter/linter.ts +++ b/packages/cli/src/services/linter/linter.ts @@ -40,7 +40,7 @@ export async function lint(documents: Array, flags: ILintConfig } const targets = [...targetUris, ...fileDescriptors]; - if (targetUris.length === 0) { + if (targets.length === 0) { throw new CLIError(`No files found to lint. Please check your file path and extension and try again`); }