Skip to content

Commit 3187693

Browse files
authored
Fix service worker serving from cache (#56)
* Fix service worker serving from cache * Fix SW test
1 parent d60baeb commit 3187693

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-storefront",
3-
"version": "7.7.0",
3+
"version": "7.7.1",
44
"description": "Build and deploy e-commerce progressive web apps (PWAs) in record time.",
55
"module": "./index.js",
66
"license": "Apache-2.0",

service-worker/bootstrap.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,10 @@ self.addEventListener('fetch', event => {
252252
event.respondWith(
253253
(async function() {
254254
try {
255+
const cacheResponse = await caches.match(event.request)
256+
if (cacheResponse) {
257+
return cacheResponse
258+
}
255259
return await fetch(event.request)
256260
} finally {
257261
if (toResume.size) {

test/bootstrap.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import makeServiceWorkerEnv from 'service-worker-mock'
2-
import makeFetchMock from 'service-worker-mock/fetch'
32

43
let sw
54

@@ -15,7 +14,7 @@ describe('bootstrap', () => {
1514
expiration: { ExpirationPlugin: jest.fn() },
1615
routing: { registerRoute: jest.fn() },
1716
}
18-
Object.assign(global, serviceWorkerEnv, makeFetchMock())
17+
Object.assign(global, serviceWorkerEnv)
1918
jest.resetModules()
2019
sw = require('../service-worker/bootstrap')
2120
})
@@ -90,7 +89,7 @@ describe('bootstrap', () => {
9089
it('should resume prefetches when non-prefetch fetch is done', async () => {
9190
const toResume = sw.__get__('toResume')
9291
toResume.add([{ path: '', apiVersion: 'v1' }])
93-
await self.trigger('fetch')
92+
await self.trigger('fetch', '')
9493
expect(toResume.size).toEqual(0)
9594
})
9695

0 commit comments

Comments
 (0)