Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRepos.net login doesn't survive a restart of Storeman #146

Open
direc85 opened this issue Jul 22, 2021 · 1 comment
Open

OpenRepos.net login doesn't survive a restart of Storeman #146

direc85 opened this issue Jul 22, 2021 · 1 comment
Labels
bug This is indeed a bug help wanted Support is needed to proceed

Comments

@direc85
Copy link
Contributor

direc85 commented Jul 22, 2021

Sony Xperia 10 II with SFOS 4.0.1.24 (aarch64), reproduced with Storeman 0.2.7-1, and with self-built 0.2.8-2.

Storeman seems to lose track of OpenRepos.net credentials. This is how I'm able to trigger it:

  • Log Storeman out of OpenRepos account
  • Close and open Storeman
  • Log Storeman in to OpenRepos account, let Storeman save the password
  • The Settings page item only lets you log out (as expected)

And to break it, close and open Storeman. The Settings page OpenRepos item

  • displays your avatar (you are logged in)
  • text doesn't contain your avatar name (you are logged out)
  • long press shows you the log out menu item (you are logged in)
  • short press takes you to login page (you are logged out)

Commenting doesn't work either, so I guess Storeman thinks you should be logged in, but you're not. The log out menu item does nothing, and logging in again fixes the inconsistent state. After that you are logged in - until you restart Storeman again.

If I, however, log in without checking saving the password on the device, restarting Storeman keeps me logged in (at least until the login expires on OpenRepos' side).

Everything works as expected, if the "save the password to device" is not checked when logging in to OpenRepos.net account. It breaks only when selected.

@Olf0 Olf0 changed the title OpenRepos.net login doesn't survive reboot OpenRepos.net login doesn't survive a restart of Storeman Mar 17, 2022
@Olf0 Olf0 added bug This is indeed a bug help wanted Support is needed to proceed labels May 18, 2023
@Olf0
Copy link
Member

Olf0 commented Sep 2, 2023

Seven.of.nine@FSO (Andrea), wrote at FSO on 2023-04-03:

That confirms my assumption that there’s a little bug somewhere in the storeman app or maybe in the ‘save store’ mechanism of SFOS. BTW, credentials of browser and mail app are always remembered properly, this never fails on my devices.

While the Jolla's Mail application is proprietary, their Browser app is not. Hence anyone can analyse how Jolla's Browser app handles this and compare it with the corresponding source code of Storeman in order to identify differences, which might result in the issue discussed here. Any technical analysis to resolve this issue or even a PR is always welcome!

P.S.:

Seven.of.nine@FSO (Andrea) additionally wrote at FSO on 2023-04-07 WRT this statement from the initial posting of this thread, which is quoted first, below.

If I, however, log in without checking saving the password on the device, restarting Storeman keeps me logged in (at least until the login expires on OpenRepos' side).

Everything works as expected, if the "save the password to device" is not checked when logging in to OpenRepos.net account. It breaks only when selected.

I’m sorry, have to report that your suggestion works only fine on Volla / 4.4.0.72 but unfortunately NOT on Xperia 10 / 4.5.0.19.
[Followed by some details observed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is indeed a bug help wanted Support is needed to proceed
Projects
None yet
Development

No branches or pull requests

2 participants