You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I have UI tests for a component library. After upgrading from one of the v6 beta versions to the latest 6.5.3 version, they are failing because the tests aren't able to navigate to different tabs after updating text inputs. The Navigation component used to be inside the KeyboardAvoidingView, thus allowing you to directly switch over to other tabs after editing text.
A common usecase for this is: a) switch into the Addons tab to update some prop value under the Controls addon, b) update the text input value of a control, c) directly switch back to Canvas to view updated story.
Describe the solution you'd like
Move the Navigation component inside the KeyboardAvoidingView
Describe alternatives you've considered
Alternatively, I should be able to use shouldDisableKeyboardAvoidingView: true. However, this doesn't work because the KeyboardAvoidingView is only disabled on the Canvas tab (see code). This seems like a bug to me that should probably also be fixed, but including the Navigation container inside the avoiding view makes sense to me unless there is a strong product reason not to.
Are you able to assist bring the feature to reality?
Although I haven't contributed to this project before, this seems like a small enough change where I could probably put up a PR for it if the maintainers don't have bandwidth.
Additional context
Screenshots for context:
Navigation not avoiding keyboard
Disabling KeyboardAvoidingView doesn't work in Addons tab
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I have UI tests for a component library. After upgrading from one of the v6 beta versions to the latest 6.5.3 version, they are failing because the tests aren't able to navigate to different tabs after updating text inputs. The
Navigation
component used to be inside theKeyboardAvoidingView
, thus allowing you to directly switch over to other tabs after editing text.A common usecase for this is: a) switch into the Addons tab to update some prop value under the Controls addon, b) update the text input value of a control, c) directly switch back to Canvas to view updated story.
Describe the solution you'd like
Move the
Navigation
component inside theKeyboardAvoidingView
Describe alternatives you've considered
Alternatively, I should be able to use
shouldDisableKeyboardAvoidingView: true
. However, this doesn't work because theKeyboardAvoidingView
is only disabled on the Canvas tab (see code). This seems like a bug to me that should probably also be fixed, but including theNavigation
container inside the avoiding view makes sense to me unless there is a strong product reason not to.Are you able to assist bring the feature to reality?
Although I haven't contributed to this project before, this seems like a small enough change where I could probably put up a PR for it if the maintainers don't have bandwidth.
Additional context
Screenshots for context:
Navigation not avoiding keyboard
Disabling KeyboardAvoidingView doesn't work in Addons tab
The text was updated successfully, but these errors were encountered: