Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Navigation component inside the KeyboardAvoidingView #485

Open
niklas-dave opened this issue Jun 9, 2023 · 1 comment
Open

Comments

@niklas-dave
Copy link

Is your feature request related to a problem? Please describe.
I have UI tests for a component library. After upgrading from one of the v6 beta versions to the latest 6.5.3 version, they are failing because the tests aren't able to navigate to different tabs after updating text inputs. The Navigation component used to be inside the KeyboardAvoidingView, thus allowing you to directly switch over to other tabs after editing text.

A common usecase for this is: a) switch into the Addons tab to update some prop value under the Controls addon, b) update the text input value of a control, c) directly switch back to Canvas to view updated story.

Describe the solution you'd like
Move the Navigation component inside the KeyboardAvoidingView

Describe alternatives you've considered
Alternatively, I should be able to use shouldDisableKeyboardAvoidingView: true. However, this doesn't work because the KeyboardAvoidingView is only disabled on the Canvas tab (see code). This seems like a bug to me that should probably also be fixed, but including the Navigation container inside the avoiding view makes sense to me unless there is a strong product reason not to.

Are you able to assist bring the feature to reality?
Although I haven't contributed to this project before, this seems like a small enough change where I could probably put up a PR for it if the maintainers don't have bandwidth.

Additional context
Screenshots for context:

Navigation not avoiding keyboard

Simulator Screen Shot - iPhone 14 - 2023-06-09 at 13 44 52

Disabling KeyboardAvoidingView doesn't work in Addons tab

Simulator Screen Shot - iPhone 14 - 2023-06-09 at 13 45 32

@dannyhw
Copy link
Member

dannyhw commented Jun 25, 2023

sorry for the late response, will try to look into this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants