Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Inconsistent operations of NFS and SMB shares via dataset.Manager #23

Open
raamsri opened this issue Jan 5, 2025 · 0 comments
Open
Assignees
Labels
help wanted Extra attention is needed Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod ZFS Related to ZFS package

Comments

@raamsri
Copy link
Contributor

raamsri commented Jan 5, 2025

Bug Report

Description

The current ZFS share/unshare implementation has several limitations and inconsistencies that need to be addressed.

Current Behavior

  1. When sharenfs and sharesmb properties are set to "off", they default to legacy mode which doesn't work with zfs share
  2. When these properties have values set, they are exposed by default and require additional handling
  3. The sharesmb functionality is basic and requires manual configuration in smb.conf

Expected Behavior

  1. Share/unshare operations should work(or not work at all?) consistently regardless of property settings
  2. Better integration with SMB sharing without requiring manual smb.conf modifications
  3. Clear handling of legacy vs. new sharing mechanisms

Setup

  • Component: ZFS Dataset Management
  • Affects: share/unshare operations
  • File: dataset.go

Additional Context

This issue impacts the reliability and usability of ZFS dataset sharing functionality. The current implementation may lead to unexpected behavior and requires manual intervention.

Notes/Suggestions

Potential solutions:

  1. Implement proper detection and handling of legacy sharing, which is likely to be the way to go? Explore?
  2. Add automated SMB configuration management
  3. Document clear workflows for different sharing scenarios
@raamsri raamsri added help wanted Extra attention is needed Needs Investigation The issue requires analysis to understand the root cause. ZFS Related to ZFS package Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod and removed Needs Investigation The issue requires analysis to understand the root cause. labels Jan 5, 2025
@raamsri raamsri self-assigned this Jan 30, 2025
@raamsri raamsri changed the title bug: Inconsistent operations of NFS and SMB shares via dataset.Manager Share/Unshare methods. bug: Inconsistent operations of NFS and SMB shares via dataset.Manager Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Needs Decision The issue is understood, but the best solution is undecided. Wait for a decision before writing cod ZFS Related to ZFS package
Projects
None yet
Development

No branches or pull requests

1 participant