Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Pool API Refactoring TODO #38

Open
4 tasks
raamsri opened this issue Jan 5, 2025 · 0 comments
Open
4 tasks

feature: Pool API Refactoring TODO #38

raamsri opened this issue Jan 5, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers Needs Fix The issue is understood and ready for code to be written.

Comments

@raamsri
Copy link
Contributor

raamsri commented Jan 5, 2025

Feature Request

Summary

Refactor Pool APIs to use request body for parameters instead of URL parameters

Motivation

Maintain consistency with Dataset APIs and improve parameter handling

Detailed Design

  1. API Changes:
    // filepath: pkg/zfs/api/routes.go
    // Current:
    // GET /pools/:name/properties/:property
    // Proposed:
    // GET /pools/properties
    // Body: {"name": "pool1"}
  2. Implementation:
  • Update route definitions
  • Add request/response structs
  • Update handlers
  • Add validation middleware

Acceptance Criteria

  • Consistent API design
  • Parameter validation
  • Error handling
  • Documentation
@raamsri raamsri added enhancement New feature or request good first issue Good for newcomers Needs Fix The issue is understood and ready for code to be written. labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Needs Fix The issue is understood and ready for code to be written.
Projects
None yet
Development

No branches or pull requests

1 participant