You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented. > I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool. #1482 (comment)
ideally, Sniffer should have a primitive to assert a connection was broken... but that is currently blocked by #1389 so we bypassed that by asserting that a port is free inside the test
requires further investigation, we're not sure if "outdated" job_id is a sufficient criteria for rejecting shares
additionally, this test could potentially require a way to intercept/replace Sv1 messages (Sv1 Sniffer?), which could be a substantial engineering effort
so for now, I'd postpone (and potentially discard) this migration
interop-proxy-with-multi-ups-extended
?
interop-proxy-with-multi-ups
?
jds-do-not-fail-on-wrong-tsdatasucc
?
jds-do-not-stackoverflow-when-no-token
jds-setupconnection-with-async-support
?
the async flag of SetupConnection is being replaced via stratum-mining/sv2-spec#121, so this test should change strategy
jds-setupconnection-without-async-support
?
the async flag of SetupConnection is being replaced via stratum-mining/sv2-spec#121, so this test should change strategy
pool-sri-test-1-standard
pool-sri-test-close-channel
potential removal
test motivation is not clear
do we even want tProxy to shutdown just because pool closed a channel?
this table should guide the CI migration away from MG
MG_reject_auth
doesn't make sense> Probably this was a test related to some initial work related to authentication mechanisms which were never really implemented.
> I think we should add a proper test in the future, as soon as we will have some kind of auth system in place on the Pool.
#1482 (comment)
Sniffer
should have a primitive to assert a connection was broken... but that is currently blocked by #1389 so we bypassed that by asserting that a port is free inside the testadditionally, this test could potentially require a way to intercept/replace Sv1 messages (Sv1 Sniffer?), which could be a substantial engineering effort
so for now, I'd postpone (and potentially discard) this migration
async
flag ofSetupConnection
is being replaced via stratum-mining/sv2-spec#121, so this test should change strategyasync
flag ofSetupConnection
is being replaced via stratum-mining/sv2-spec#121, so this test should change strategydo we even want tProxy to shutdown just because pool closed a channel?
Aside from the MG tests listed above, #1077 should also be completed within the context of this effort.
The text was updated successfully, but these errors were encountered: