From 888873c8488191894b17327efecbdab8cae597b2 Mon Sep 17 00:00:00 2001 From: Richard Osborne Date: Tue, 7 Oct 2025 19:06:08 -0500 Subject: [PATCH] add comment that explains 10ms float literal value + rename ms -> interval * rename ms -> interval because scheduledTimerWithTimeInterval expects "time in seconds" --- browser-mac.mm | 4 ++-- obs-browser-plugin.cpp | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/browser-mac.mm b/browser-mac.mm index 52ef1ca23..77820b628 100644 --- a/browser-mac.mm +++ b/browser-mac.mm @@ -75,10 +75,10 @@ void DoCefMessageLoop(int) }); } -void DoCefMessageLoopTimer(float ms) +void DoCefMessageLoopTimer(float interval) { cefTimer = [NSTimer - scheduledTimerWithTimeInterval:ms + scheduledTimerWithTimeInterval:interval repeats:YES block:^(NSTimer *) { CefDoMessageLoopWork(); diff --git a/obs-browser-plugin.cpp b/obs-browser-plugin.cpp index fe69583ec..a26e42276 100644 --- a/obs-browser-plugin.cpp +++ b/obs-browser-plugin.cpp @@ -545,7 +545,8 @@ extern "C" EXPORT void obs_browser_initialize(obs_data_t *settings) ExecuteTask([&settings]() { BrowserInit(settings); - DoCefMessageLoopTimer(0.01f); // Do not block the main queue so we avoid calling CefRunMessageLoop() + const float interval = 0.01f; // 10ms, for ex. 16.6ms = 60fps. We want a bit more than 60fps to keep CEF happy? + DoCefMessageLoopTimer(interval); // Do not block the main queue so we avoid calling CefRunMessageLoop() }); #else auto binded_fn = bind(BrowserManagerThread, settings);