Show the user when there is no compatible video #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aah, this looks great! Sorry I've been AWOL lately, but I'm back and gonna start picking up the maintenance here. I'll take a deeper look at the code and try running it on my machine today, and go from there :) |
|
Hey @wmww -- Looking at #14 it seems like there's some future scope of supporting multiple For now, we could still just auto-select the first video, but maybe down the road we are set up to build some type of picker inside the popup to choose between the multi-video page. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Feel free to ignore/close if the project is no longer maintained. I'm considering using this as a base for my own open source casting project, so I figured I'd fix a bug just to get a feel of the code.