chore: Update TypeScript-ESLint (#78)

* chore: Update TypeScript-ESLint
* Update pnpm-lock.yaml

Author: Jason3S

eslint.config.js

@@ -2,19 +2,12 @@
 
 import eslint from '@eslint/js';
 import nodePlugin from 'eslint-plugin-n';
-import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended';
 import simpleImportSort from 'eslint-plugin-simple-import-sort';
 import tsEslint from 'typescript-eslint';
 
-// mimic CommonJS variables -- not needed if using CommonJS
-// import { FlatCompat } from "@eslint/eslintrc";
-// const __dirname = fileURLToPath(new URL('.', import.meta.url));
-// const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: eslint.configs.recommended});
-
 export default tsEslint.config(
     eslint.configs.recommended,
     nodePlugin.configs['flat/recommended'],
-    eslintPluginPrettierRecommended,
     ...tsEslint.configs.recommended,
     {
         ignores: ['**/dist/**', '**/node_modules/**', '/*/*/coverage/**'],

package.json

@@ -45,19 +45,14 @@
   "homepage": "https://github.com/streetsidesoftware/perf-insight#readme",
   "license": "MIT",
   "devDependencies": {
-    "@eslint/eslintrc": "^3.1.0",
     "@eslint/js": "^9.8.0",
     "@tsconfig/node20": "^20.1.4",
     "@types/node": "^20.14.14",
     "@vitest/coverage-v8": "^2.0.5",
     "cspell": "^8.13.2",
     "cspell-trie-lib": "^8.13.2",
     "eslint": "^9.8.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-n": "^17.10.2",
-    "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "globals": "^15.9.0",
     "inject-markdown": "^3.1.0",
@@ -66,7 +61,7 @@
     "prettier": "^3.3.3",
     "ts-node": "^10.9.2",
     "typescript": "^5.5.4",
-    "typescript-eslint": "^7.18.0",
+    "typescript-eslint": "^8.0.1",
     "vite": "^5.4.0",
     "vitest": "^2.0.5"
   }

packages/perf-insight/src/app.mts

@@ -64,7 +64,7 @@ export async function app(program = defaultCommand): Promise<Command> {
 
             await spawnRunners(files, options);
 
-            process.exitCode ? console.log(chalk.red('failed.')) : console.log(chalk.green('done.'));
+            return process.exitCode ? console.log(chalk.red('failed.')) : console.log(chalk.green('done.'));
         });
 
     program.showHelpAfterError();
@@ -127,8 +127,8 @@ function spawnRunner(args: string[]): Promise<number | undefined> {
             if (completed) return;
             clearTimeout(timeout);
             completed = true;
-            process.connected && process.disconnect();
-            error ? reject(error) : resolve(exitCode);
+            if (process.connected) process.disconnect();
+            return error ? reject(error) : resolve(exitCode);
         }
 
         process.on('error', (err) => {

packages/perf-insight/src/perfSuite.mts

@@ -269,11 +269,7 @@ async function runTests(
             }
         }
     };
-    const reportTestIteration =
-        progress?.testIteration ??
-        (() => {
-            spinner.isSpinning && spinner.render();
-        });
+    const reportTestIteration = progress?.testIteration ?? (() => spinner.isSpinning && spinner.render());
 
     const context: RunnerContext = {
         test,
@@ -304,7 +300,7 @@ async function runTests(
     }
 
     function addTest(test: TestDefinition) {
-        filterTest(test.name) && tests.push(test);
+        if (filterTest(test.name)) tests.push(test);
     }
 
     function test(name: string, method: () => void, timeout?: number): void {