Missing test for security limits being disabled

silverbacknet · web-flow · commit df1936aaf2c0 · 2025-01-26T00:09:44.000-08:00
diff --git a/libheif/nclx.cc b/libheif/nclx.cc
@@ -378,7 +378,7 @@ Error Box_colr::parse(BitstreamRange& range, const heif_security_limits* limits)
     }
 
     uint64_t profile_size_64 = get_box_size() - get_header_size() - 4;
-    if (profile_size_64 > limits->max_color_profile_size) {
+    if (limits->max_color_profile_size && profile_size_64 > limits->max_color_profile_size) {
       return Error(heif_error_Invalid_input, heif_suberror_Security_limit_exceeded, "Color profile exceeds maximum supported size");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ Error Box_colr::parse(BitstreamRange& range, const heif_security_limits* limits)`
`378`	`378`	`}`
`379`	`379`
`380`	`380`	`uint64_t profile_size_64 = get_box_size() - get_header_size() - 4;`
`381`		`- if (profile_size_64 > limits->max_color_profile_size) {`
	`381`	`+ if (limits->max_color_profile_size && profile_size_64 > limits->max_color_profile_size) {`
`382`	`382`	`return Error(heif_error_Invalid_input, heif_suberror_Security_limit_exceeded, "Color profile exceeds maximum supported size");`
`383`	`383`	`}`
`384`	`384`