Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor not getting damaged when punched by any mobs. #177

Open
LandonAConway opened this issue Jun 3, 2020 · 6 comments
Open

Armor not getting damaged when punched by any mobs. #177

LandonAConway opened this issue Jun 3, 2020 · 6 comments

Comments

@LandonAConway
Copy link

Regardless of which mob mod, or any armor you are wearing, armor is not getting damaged in any way shape or form when bieng punched by mobs. This is frustrating. Please fix it.

@LoneWolfHT
Copy link
Contributor

https://github.com/minetest-mods/3d_armor has taken up maintaining this until stu returns from the dead. Can you reproduce the bug with that version?

@ghost
Copy link

ghost commented Jun 4, 2020

3d_armor.tar.gz

@LandonAConway
Copy link
Author

I have discovered the issue in the api.lua. The reason why this is happening is because the armor is not programmed to become damaged unless the "puncher" object, is a player. Since mobs are not players, they cannot damage armor unless you input a player in the punch method that is commonly executed for a mob to attack. This is not practical since mobs are so popular. Mobs should be able to interact with armor too. I'm not sure what this person was thinking but it needs to be changed.

@LoneWolfHT
Copy link
Contributor

Was it changed in the minetest-mods repo I linked @LandonAConway ?

@sirrobzeroone
Copy link

cross reference
minetest-mods#24

@mckaygerhard
Copy link

I have discovered the issue in the api.lua. The reason why this is happening is because the armor is not programmed to become damaged unless the "puncher" object, is a player. Since mobs are not players, they cannot damage armor unless you input a player in the punch method that is commonly executed for a mob to attack. This is not practical since mobs are so popular. Mobs should be able to interact with armor too. I'm not sure what this person was thinking but it needs to be changed.

he issue minetest-mods#57 may be related to? it defines on_punched and means to set damage to true! . damage never get true.. as i know event if that is own 3d_armor definition.. there's no such callback on minetest api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants