Skip to content

Windows support #2

@suchipi

Description

@suchipi

It'd be nice to support windows, too. I think the only incompatible code is in Job#run:

  • These should use the path module instead of template literals:

const jobDir = `jobs/${taskName}/${commitSha}`;

  • We shouldn't use sh to spawn the process on windows:

"sh",

I'm not sure if windows can run eg. ./quinci/master, it might have to run ./quinci/master.bat or etc.

Also we'd be assuming that git is in the PATH on windows, just like we do for unix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions