Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set -Werror #126

Open
t-bre opened this issue Oct 22, 2022 · 0 comments
Open

build: set -Werror #126

t-bre opened this issue Oct 22, 2022 · 0 comments
Labels
build Build and toolchain

Comments

@t-bre
Copy link
Member

t-bre commented Oct 22, 2022

Description

Compilers should be set to error on warnings.

Rationale: build caching means that a warning can appear once when you build the file, and then not appear again until you clean the build system. This makes it easier for warnings to slip through. Theoretically the linter should catch it, but it's better to be safe.

If we can find a way to make cmake remember previous warnings and print them out again that would be a reasonable alternative.

@t-bre t-bre added feature New features build Build and toolchain and removed feature New features labels Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build and toolchain
Projects
None yet
Development

No branches or pull requests

1 participant